Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

systemd-networkd: parse DHCP option 119 (Domain Search List) #2710

Closed
mikken opened this issue Feb 23, 2016 · 7 comments · Fixed by #5932
Closed

systemd-networkd: parse DHCP option 119 (Domain Search List) #2710

mikken opened this issue Feb 23, 2016 · 7 comments · Fixed by #5932
Labels
dhcp RFE 🎁 Request for Enhancement, i.e. a feature request

Comments

@mikken
Copy link

mikken commented Feb 23, 2016

Submission type

Request for enhancement (RFE)

systemd version the issue has been seen with

229

Used distribution

Arch Linux ARM

Description

Currently systemd-networkd looks into DHCP option 15 (DNS domain suffix) to put into its domain list used for searching. Since I'd like to have 2 domains in the list, I need it to also parse option 119 (Domain Search List) when UseDomains=yes is set.
@poettering poettering added RFE 🎁 Request for Enhancement, i.e. a feature request dhcp labels Feb 23, 2016
@sjpotter
Copy link

sjpotter commented Jun 2, 2016

this impacts me too. In GCE google's DHCP provides multiple search domains and google.internal is one of them and many tools try to access just "metadata" instead of "metadata.google.internal".

@marineam
Copy link
Contributor

marineam commented Jun 2, 2016

For reference, the only slightly funky thing about implementing DHCP's Domain Search List is that it uses DNS style name compression. The equivalent option in DHCPv6 has already been implemented back in #924 and I'll bet dhcp6_option_parse_domainname can be easily reused for v4.

@euank euank mentioned this issue Jun 6, 2016
Closed
@thetuxkeeper
Copy link

Is there any progress on this issue? this impacts us too. We need to specify more than one domain for the dhcp clients.

euank added a commit to euank/kubernetes that referenced this issue Jul 7, 2016
@euank
cluster/gce/coreos: Add gce metadata search domain
050f581 
Works around systemd/systemd#2710
Ref: kubernetes#24563
@wonderfly
Copy link
Contributor

Echoing what @thetuxkeeper asked. Is this on the roadmap?

@jonesmz
Copy link

jonesmz commented Apr 28, 2017

Was recently effected by the lack of option 119. Could we get a comment on if this is being planned for any future release?

@poettering
Copy link
Member

Well, adding this is definitely on the roadmap, but to actually happen it would need somebody work on it. If you want it to happen quickly best would be to contribute a patch!

wonderfly added a commit to wonderfly/systemd that referenced this issue May 10, 2017
@wonderfly
network: Implement DHCP Option 119 (Domain Search List)
f3dd9e2 
This adds a modified version of dhcp6_option_parse_domainname() that is
able to parse compressed domain names, borrowing the idea from
dns_packet_read_name(). It also adds pieces in networkd-link and
networkd-manager to properly save/load the added option field.

This resolves systemd#2710.
@wonderfly wonderfly mentioned this issue May 10, 2017
Merged
@wonderfly
Copy link
Contributor

If you want it to happen quickly best would be to contribute a patch

@poettering I sorted out a patch, #5932. Anybody you have in mind could be a good reviewer?

wonderfly added a commit to wonderfly/systemd that referenced this issue May 12, 2017
@wonderfly
network: Implement DHCP Option 119 (Domain Search List)
96316bc 
This adds a modified version of dhcp6_option_parse_domainname() that is
able to parse compressed domain names, borrowing the idea from
dns_packet_read_name(). It also adds pieces in networkd-link and
networkd-manager to properly save/load the added option field.

This resolves systemd#2710.
wonderfly added a commit to wonderfly/systemd that referenced this issue May 12, 2017
@wonderfly
network: Implement DHCP Option 119 (Domain Search List)
b6327b2 
This adds a modified version of dhcp6_option_parse_domainname() that is
able to parse compressed domain names, borrowing the idea from
dns_packet_read_name(). It also adds pieces in networkd-link and
networkd-manager to properly save/load the added option field.

This resolves systemd#2710.
keszybz pushed a commit that referenced this issue May 13, 2017
@wonderfly @keszybz
network: Implement DHCP Option 119 (Domain Search List) (#5932)
b85bc55 
This adds a modified version of dhcp6_option_parse_domainname() that is
able to parse compressed domain names, borrowing the idea from
dns_packet_read_name(). It also adds pieces in networkd-link and
networkd-manager to properly save/load the added option field.

Resolves #2710.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
dhcp RFE 🎁 Request for Enhancement, i.e. a feature request
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

network: Implement DHCP Option 119 (Domain Search List) wonderfly/systemd
7 participants
@marineam @jonesmz @sjpotter @poettering @mikken @thetuxkeeper @wonderfly