Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFE: support root on LUKS in gpt-auto-generator #859

Closed
gdamjan opened this issue Aug 4, 2015 · 4 comments
Closed

RFE: support root on LUKS in gpt-auto-generator #859

gdamjan opened this issue Aug 4, 2015 · 4 comments
Labels
gpt-auto RFE 🎁 Request for Enhancement, i.e. a feature request

Comments

@gdamjan
Copy link
Contributor

gdamjan commented Aug 4, 2015

My root filesystem is LUKS encrypted (no LVM, just LUKS on /dev/sda3).

dir=$(mktemp -d)
sudo SYSTEMD_LOG_LEVEL=debug ./systemd-gpt-auto-generator $dir $dir $dir
/dev/dm-0: not a partitioned device, ignoring.

afterwards $dir is empty. I'd expect at least boot and swap units.

it seems that inside add_mounts(void), get_block_device returns the /dev/md-0 device (/dev/mapper/root) and then gpt-auto-generator calls enumerate_partitions(devno) on the mapper.

@poettering
Copy link
Member

Yes, gpt-auto-discovery only works on if the root disk is on a GPT partition tables. Hence its name. What did you expect?

@gdamjan
Copy link
Contributor Author

gdamjan commented Aug 5, 2015

just to make it clear, my disk is GPT partitioned. boot and swap are not LUKS encrypted of course.

http://www.freedesktop.org/wiki/Specifications/DiscoverablePartitionsSpec/ suggests that it shouldn't be different if the partitions are LUKS encrypted.

Also, with the previous EFI boot automount the same partitioning scheme did create the boot mount. That's why expected it to continue to work.

@poettering poettering changed the title gpt-auto-generator fails when root is on LUKS RFE: support root on LUKS in gpt-auto-generator Aug 5, 2015
@poettering poettering added the RFE 🎁 Request for Enhancement, i.e. a feature request label Aug 5, 2015
@poettering
Copy link
Member

Ah, got it now. Actually this has been on the TODO list for a while, see the TODO file in the git repo, look for "gpt-auto-generator" there...

poettering added a commit to poettering/systemd that referenced this issue Dec 15, 2016
Previously, we supported GPT auto-discovery for /home and /srv, but not
for the root partition. Add that, too.

Fixes: systemd#859
@poettering
Copy link
Member

Fix waiting in #4879.

poettering added a commit to poettering/systemd that referenced this issue Dec 16, 2016
Previously, we supported GPT auto-discovery for /home and /srv, but not
for the root partition. Add that, too.

Fixes: systemd#859
poettering added a commit to poettering/systemd that referenced this issue Dec 21, 2016
Previously, we supported GPT auto-discovery for /home and /srv, but not
for the root partition. Add that, too.

Fixes: systemd#859
poettering added a commit to poettering/systemd that referenced this issue Dec 21, 2016
Previously, we supported GPT auto-discovery for /home and /srv, but not
for the root partition. Add that, too.

Fixes: systemd#859
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gpt-auto RFE 🎁 Request for Enhancement, i.e. a feature request
Development

No branches or pull requests

2 participants