Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

systemd rpm macros contain --user --global options clash #9027

Closed
tguruswamy opened this issue May 18, 2018 · 0 comments
Closed

systemd rpm macros contain --user --global options clash #9027

tguruswamy opened this issue May 18, 2018 · 0 comments
Labels
bug 🐛 Programming errors, that need preferential fixing rpm
Milestone

Comments

@tguruswamy
Copy link

Since at least v217 / 7c67f0f, systemd/src/core/macros.systemd.in has contained scriptlets to help with rpm packages providing user services, of the type

%systemd_user_preun() \
if [ $1 -eq 0 ] ; then \
        # Package removal, not upgrade \
        systemctl --no-reload --user --global disable %{?*} > /dev/null 2>&1 || : \
fi \
%{nil}

However --user --global is actually an options clash. Luckily --global was specified last so the macros function as intended at the moment, but this did cause considerable confusion as a packager as to what these macros were actually doing and whether they worked.

@poettering poettering added this to the v239 milestone May 18, 2018
@poettering poettering added rpm bug 🐛 Programming errors, that need preferential fixing labels May 18, 2018
@yuwata yuwata closed this as completed in 28d36da May 20, 2018
kyle-walker pushed a commit to kyle-walker/systemd that referenced this issue Nov 15, 2018
Fixes systemd#9027.

(cherry picked from commit 28d36da)
Resolves: #1582383
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Programming errors, that need preferential fixing rpm
Development

No branches or pull requests

3 participants