tests: run fuzzers four times in a row #10794
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evverx
force-pushed
the
run-fuzzers-four-times-in-a-row
branch
from
40c7cc4
to
0a22268
Compare
|
Judging by it seems to be working. I'm tempted to create a label called "ci-fails/doesn't-need-rework" :-) I'll wait for #10793 to be merged, rebase it on top to see how it goes. |
This should help to catch issues that are easily detectable by bad_build_check like the one being fixed in systemd#10793, which would totally break the build tomorrow if I hadn't run `helper.py check_build` manually.
evverx
force-pushed
the
run-fuzzers-four-times-in-a-row
branch
from
0a22268
to
4e0de26
Compare
|
Now that #10793 is merged, I rebased the PR on top of master to see how it goes. TravisCI and semaphorci should become green soon. |
|
@evverx Do you think it can be merged now? |
yuwata
reviewed
Nov 16, 2018
| @@ -30,7 +35,8 @@ int main(int argc, char **argv) { | |||
| } | |||
| printf("%s... ", name); | |||
| fflush(stdout); | |||
| (void) LLVMFuzzerTestOneInput((uint8_t*)buf, size); | |||
| for (int j = 0; j < MIN_NUMBER_OF_RUNS; j++) | |||
There was a problem hiding this comment.
BTW, I prefer here unsigned or size_t. But please ignore this now.
|
@yuwata yes, I think this PR is ready to roll. |
|
OK. Let's ignore remaining CIs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should help to catch issues that are easily detectable by
bad_build_check like the one being fixed in #10793,
which would totally break the build tomorrow if I hadn't run
helper.py check_buildmanually.