add device hwdb for IdeaPad Miix510-12ISK #11108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
poettering
reviewed
Dec 10, 2018
|
/cc @hadess |
|
also, tests don't pass, hwdb file is not properly formatted. |
poettering
added
the
ci-fails/needs-rework 🔥
|
looks ok, but please extend the comment there, do mention your device model |
poettering
added
squash-on-merge
and removed
ci-fails/needs-rework 🔥
|
Could you please squash the changes squash on your branch? |
add ACCEL_MOUNT_MATRIX for IdeaPad Miix510-12ISK multiple match expressions for Miix510 series extend comments for miix510 series Signed-off-by: Bruce Zhang <zttt183525594@gmail.com> add device hwdb for IdeaPad Miix510-12ISK Signed-off-by: Bruce Zhang <zttt183525594@gmail.com>
|
@hadess it's not really necessary to ask contributors to squash. Github can do that for us when merging, which works just as well as long as we are fine with having one patch in the end. For simple PRs like this this is good enough. We use 'please-squash-on-merge' label to mark such cases. |
keszybz
approved these changes
Dec 14, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add hwdb ACCEL_MOUNT_MATRIX for IdeaPad Miix510-12ISK