man: substantially update the docs regarding hooking sd-bus objects u… #11127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keszybz
requested changes
Dec 12, 2018
man/sd_bus_wait.xml
Outdated
|
|
||
| <para>Note that <function>sd_bus_wait()</function> is suitable only for simple programs as it does not permit | ||
| waiting for other I/O events than the ones of the bus connection itself. For more complex programs either connect | ||
| the bus connection object to an external or manual event loop using |
There was a problem hiding this comment.
"external or manual" → "external"
…p with external event loops Prompted by https://lists.freedesktop.org/archives/systemd-devel/2018-December/041817.html This also drops all references to select() from our manpages. It's 2018 after all, people should use poll(), or ppoll() or epoll().
poettering
force-pushed
the
man-sd-bus-get-fd-fix
branch
from
e60ddcf
to
077e178
Compare
|
Force pushed a new version. Only changes were the ones @keszybz pointed out (though I replicated the same ECHILD fix to the other two man pages). Taking liberty to set green label, given how minor the fixes are and given that documentation is generally pretty riskless. |
poettering
added
the
good-to-merge/waiting-for-ci 👍
keszybz
removed
the
good-to-merge/waiting-for-ci 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…p with external event loops
Prompted by https://lists.freedesktop.org/archives/systemd-devel/2018-December/041817.html
This also drops all references to select() from our manpages. It's 2018
after all, people should use poll(), or ppoll() or epoll().