network: make Link and NetDev always have the valid poiter to Manager #11412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c4397d9 introduces link_detach_from_manager() and netdev_detach_from_manager(), and they set Link::manager or NetDev::manager NULL. But, at the time e.g. link is removed, hence link_drop() is called, there may be still some asynchronous netlink call is waiting, and their callbacks hit assertion. This make {link,netdev}_detach_from_manager() just drop all references from manager, but keep the pointer to manager. Fixes systemd#11411.
|
(The reporter of the issue confirmed that this fixes the issue.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
c4397d9 introduces
link_detach_from_manager()andnetdev_detach_from_manager(), and they setLink::managerorNetDev::managerNULL.But, at the time e.g. link is removed, hence
link_drop()is called, there may be still some asynchronous netlink call is waiting, and their callbacks hit assertion.This make
{link,netdev}_detach_from_manager()just drop all references from manager, but keep the pointer to manager.Fixes #11411.