Revert PR #12378 #12739
Closed
Revert PR #12378 #12739
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @rbalint |
|
@mbiebl Thanks, I won't have much time on working on this in the next days thus doing a revert is reasonable if there is no better fix. IMO the part only moving the function could be kept since it does not cause any regression and may be useful later. |
This reverts commit 13a43c7. Fixes: systemd#12616
|
Updated as per @rbalint 's feedback |
|
Do I understand it correctly that if this PR gets merged, systemd will still be vulnerable to CVE-2018-20839? |
|
@ret2libc probably |
|
I posted a full revert now in #13109. Closing this one (yeah, I think the move should go, too, let's keep the function private if it's not used elsewhere) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR caused a regression and there is no fix available yet, so revert it for the time being
See #12616