systemd-analyze: use Table #13062
Merged
systemd-analyze: use Table #13062
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
poettering
reviewed
Jul 16, 2019
| @@ -1081,18 +1080,50 @@ static int analyze_blame(int argc, char *argv[], void *userdata) { | |||
| if (n <= 0) | |||
| return n; | |||
|
|
|||
| typesafe_qsort(times, n, compare_unit_time); | |||
| table = table_new("TIME", "UNIT"); | |||
There was a problem hiding this comment.
we should probably stick to lowercase table header fields, as the formatter uppercases them anyway, and this way the JSON output of the formatter is nicer as it uses the table header fields 1:1 for the json output.
also see:
There was a problem hiding this comment.
Let's do this in a later patch. There's already code in src/network that uses uppercase, so we should fix them all in one swell swoop.
I noticed some minor issues with formatting when reviewing this PR, but they predate the PR. I'll submit fixes separately.
keszybz
added a commit
to keszybz/systemd
that referenced
this pull request
Jul 16, 2019
systemd#13062 (comment) > the formatter uppercases them anyway, and this way the JSON output of the > formatter is nicer as it uses the table header fields 1:1 for the json > output.
|
I have posted #13074 inspired by this btw, which should allows to make putting tables together quite a bit shorter. ptal |
keszybz
added a commit
to keszybz/systemd
that referenced
this pull request
Jul 16, 2019
systemd#13062 (comment) > the formatter uppercases them anyway, and this way the JSON output of the > formatter is nicer as it uses the table header fields 1:1 for the json > output.
zachsmith
pushed a commit
to zachsmith/systemd
that referenced
this pull request
Jul 26, 2019
systemd#13062 (comment) > the formatter uppercases them anyway, and this way the JSON output of the > formatter is nicer as it uses the table header fields 1:1 for the json > output.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.