journal: Consistently capitalize printed header entries #13808
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All other entries use this style.
|
Can we go the other way? There is no reason for the second word to be capitalized, it is not a name. I think this should be "Compatible flags", "Incompatible flags", "Some ID", "Some path". |
|
bionic-amd64 failure looks unrelated to this PR. |
t-nelis
added a commit
to t-nelis/systemd
that referenced
this pull request
Oct 21, 2019
Per comments in systemd#13808.
Indeed it probably makes more sense. FWIW no strong opinion from me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All other entries use this style.