resolved-dns-query: remove dns_query_candidate_is_routable #14125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolved can't reliably determine on whether "it makes sense" to query AAAA records when not explicitly specifying it in the request, so we shouldn't remove them. After having done the resolving, applications can use RFC6724 to determine whether that address is reachable. We can't know whether an address is reachable before having resolved it and inspecting the routing table, and not resolving AAAA just because there's no IPv6 default route on the main interface link them breaks various setups, including IPv6-providing wireguard tunnels on a non-dualstacked environment. Fixes systemd#5782 Fixes systemd#5915 Fixes systemd#8017
|
After that, |
|
ping @yuwata |
|
Is there anything preventing this from getting merged? |
|
This is removing in my opinion useful feature, because that feature had implementation error. I think the problem with it was it checked only routes on interface associated with the queried server. Instead, it should have checked global routes and if there were ANY not link-local route, then it should have enabled AAAA. Just one route to VPN should enable AAAA queries or A queries. If that have been fixed instead, it would behave correctly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolved can't reliably determine on whether "it makes sense" to query
AAAA records when not explicitly specifying it in the request, so we
shouldn't remove them.
After having done the resolving, applications can use RFC6724 to
determine whether that address is reachable.
We can't know whether an address is reachable before having resolved it
and inspecting the routing table, and not resolving AAAA just because
there's no IPv6 default route on the main interface link them breaks
various setups, including IPv6-providing wireguard tunnels on a
non-dualstacked environment.
Fixes #5782
Fixes #5915
Fixes #8017
cc @poettering @ssahani @andir @Mic92 @petabyteboy @fpletz