various chase_symlink() fixes #14689
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
poettering
force-pushed
the
portable-chase-symlink-fix
branch
from
fd1af77
to
c20fabc
Compare
dnicolodi
reviewed
Jan 28, 2020
…t unresolved Previously there was a weird asymmetry: initially we'd resolve the specified prefix path when chasing symlinks together with the actual path we were supposed to cover, except when we hit an absolute symlink where we'd use the root as it was. Let's unify handling here: the prefix path is never resolved, and always left as it is. This in particular fixes issues with symlinks in the prefix path, as that confused the check that made sure we never left the root directory. Fixes: systemd#14634 Replaces: systemd#14635
Let's eat up multiple slashes. Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1787089 Replaces: systemd#14687
This corrects the fix b81b9d4, making the test operate like it was originally.
poettering
force-pushed
the
portable-chase-symlink-fix
branch
from
c20fabc
to
bcb1ead
Compare
bluca
approved these changes
Jan 28, 2020
|
LGTM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.