Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix some failures in test-cgroup #14901

Merged
merged 6 commits into from
Mar 11, 2020
Merged

Commits on Feb 18, 2020

  1. test: fix some failures in test-cgroup

    Fix the following issues in test-cgroup:
    1, commit 65be7e0 ("pid1: do not reset subtree_control on
    already-existing units with delegation") changed the return value
    of cg_create () as follows:
    "Returns 0 if the group already existed, 1 on success, negative
    otherwise."
    So we need to modify the test cases related to cg_create ().
    
    2, commit efdb023 ("core: unified cgroup hierarchy support")
    changed cg_delete () to cg_rmdir (), so the test cases also need
    to be adjusted a bit.
    
    3. There is no cleanup of "test-a". If we execute test-cgroup
    multiple times, we will encounter an error.
    
    Signed-off-by: Wen Yang <wenyang@linux.alibaba.com>
    taskset committed Feb 18, 2020
    Configuration menu
    Copy the full SHA
    4ef0ac8 View commit details
    Browse the repository at this point in the history

Commits on Mar 10, 2020

  1. Configuration menu
    Copy the full SHA
    b35e997 View commit details
    Browse the repository at this point in the history
  2. basic/cgroup-util: modernize cg_split_spec()

    Those cryptic one letter variable names, yuck!
    keszybz committed Mar 10, 2020
    Configuration menu
    Copy the full SHA
    2a8020f View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    1c13219 View commit details
    Browse the repository at this point in the history
  4. test-cgroup: do not require root to pass

    Nowadays with delegation to the user instance, we can make this work as non-root
    easily. If we still get access denied, just skip the test.
    keszybz committed Mar 10, 2020
    Configuration menu
    Copy the full SHA
    67da332 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    4f2db15 View commit details
    Browse the repository at this point in the history