Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build-sys: make man/systemd.directives.xml depend on man/custom-entit… #152

Merged
merged 1 commit into from Jun 10, 2015

Conversation

zonque
Copy link
Member

@zonque zonque commented Jun 10, 2015

…ies.ent

Currently, the following command sequence fails:

make distclean
./autogen.sh c
make distcheck

That's because the command invoked to build man/systemd.directives.xml needs
man/custom-entities.ent to function, which itself isn't a dependency.

The $(filter-out $<,$^) logic used to filter out everything from the
prerequisites except for the first word, which doesn't work anymore
now. Use $(SOURCE_XML_FILES) instead.

…ies.ent

Currently, the following command sequence fails:

  make distclean
  ./autogen.sh c
  make distcheck

That's because the command invoked to build man/systemd.directives.xml needs
man/custom-entities.ent to function, which itself isn't a dependency.

The $(filter-out $<,$^) logic used to filter out everything from the
prerequisites except for the first word, which doesn't work anymore
now. Use $(SOURCE_XML_FILES) instead.
@filbranden
Copy link
Member

Looks good.

poettering added a commit that referenced this pull request Jun 10, 2015
build-sys: make man/systemd.directives.xml depend on man/custom-entit…
@poettering poettering merged commit 6f45f8c into systemd:master Jun 10, 2015
@martinpitt
Copy link
Contributor

This caused a regression, filed issue #215 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants