CoredumpFilter= #15332
CoredumpFilter= #15332
Conversation
| if (v >= 0) { | ||
| m |= 1 << v; | ||
| continue; | ||
| } |
There was a problem hiding this comment.
shouldn't there be a syntax with "~" to remove some bits from the default?
There was a problem hiding this comment.
There could, but frankly, I'd prefer not to implement this just in case somebody might want it some day. I think this whole filter is a very fringe thing, and it's trivial to simply list the mask you want in full.
| #define COREDUMP_FILTER_MASK_DEFAULT (1u << COREDUMP_FILTER_PRIVATE_ANONYMOUS | \ | ||
| 1u << COREDUMP_FILTER_SHARED_ANONYMOUS | \ | ||
| 1u << COREDUMP_FILTER_ELF_HEADERS | \ | ||
| 1u << COREDUMP_FILTER_PRIVATE_HUGE) |
There was a problem hiding this comment.
i'd probably define COREDUMP_FILTER_TO_MASK() which does the shifting. Just to make this more readable
There was a problem hiding this comment.
It's just a shift... I think the mask would make this painfully verbose and not really clearer. (And there's two places where this would be used, so I don't think it's worth it.)
poettering
added
new-feature
reviewed/needs-rework 🔨
|
Updated with the requested changes, except where commented above. I also added on more tiny commit to add debug logging when oom_score_adj cannot be parsed. |
keszybz
removed
the
reviewed/needs-rework 🔨
poettering
added
the
good-to-merge/waiting-for-ci 👍
No description provided.