Remove seat_can_multi_session #15459
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmm, you didn't rework sd_seat_can_multi_session() to do "return 1". Accidentally forgotten, or on purpose? If so, explain plz? |
|
(lgtm otherwise) |
Follow-up for fa2cf64. Backwards-compat is retained. A short note is added in docs, in case people see sd_seat_can_multi_session() mentioned somewhere and wonder what happened to it. Also see systemd#15337 (comment).
The _sd_deprecated_ annotation gives it all away, and the comment adds no additional value.
keszybz
force-pushed
the
remove-seat_can_multi_session
branch
from
c9d984b
to
0500114
Compare
Forgotten. Sorry. Updated. |
poettering
added
the
good-to-merge/waiting-for-ci 👍
gnomesysadmins
pushed a commit
to GNOME/gnome-flashback
that referenced
this pull request
Sep 4, 2020
All seats supports multiple sessions: systemd/systemd#15337 systemd/systemd#15459 sd_seat_can_multi_session function has been deprecated and always returns true with systemd 246 or newer. Also CanMultiSession property no longer appears in D-Bus introspection data. This might have revealed bug somewhere as now generated gf_login_seat_gen_get_can_multi_session function returns false but property is supposed to be always true. Above causes user switch button to be hidden. As all seats should support multiple session remove can_multi_session check to restore user switch button in unlock dialog.
gnomesysadmins
pushed a commit
to GNOME/gnome-panel
that referenced
this pull request
Sep 4, 2020
All seats supports multiple sessions: systemd/systemd#15337 systemd/systemd#15459 sd_seat_can_multi_session function has been deprecated and always returns true with systemd 246 or newer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.