Add mkosi config for openSUSE Tumbleweed #15527
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Distributions may be build with various configs, e.g. customized rootprefix. It'd be unmaintanable to have specific mkosi.build for each supported distro. Hence, make the build script flexible yet distro oblivious.
Both hostname and uname utilities boil down to uname(2) syscall. Reduce tests dependency footprint by using uname for checking hostname too.
Some testcases in test-execute rely on existence of user groups with certain gids. However, their existence is not universally granted [1]. Although the test could be skipped in their absence and give up testing some code paths, different approach was chosen -- create dummy groups in the testing image. [1] See how systemd-sysusers allocates gids (e.g. src/test/test-uid-range.c).
keszybz
reviewed
Apr 23, 2020
.mkosi/mkosi.opensuse
Outdated
| @@ -0,0 +1,62 @@ | |||
| # SPDX-License-Identifier: LGPL-2.1+ | |||
| # | |||
| # Copyright © 2018 Michal Koutný | |||
There was a problem hiding this comment.
We removed (almost all) copyright lines, see #9320. I'd prefer to not add this one.
There was a problem hiding this comment.
No problem, removed in a force push.
The setup is meant to run against openSUSE Tumbleweed and install minimum packages necessary for successful build and passing tests. To speed up incremental build an external build directory is used.
|
We don't run mkosi in CI, so let's just merge this. |
Werkov
added a commit
to Werkov/systemd
that referenced
this pull request
May 1, 2020
User accounts of given names are necessary for the build script and tests to succeed. (Fixup of systemd#15527, too keen cleaning of dependencies and cached image caused this.)
keszybz
pushed a commit
that referenced
this pull request
May 4, 2020
User accounts of given names are necessary for the build script and tests to succeed. (Fixup of #15527, too keen cleaning of dependencies and cached image caused this.)
Werkov
added a commit
to Werkov/systemd
that referenced
this pull request
May 28, 2020
User accounts of given names are necessary for the build script and tests to succeed. (Fixup of systemd#15527, too keen cleaning of dependencies and cached image caused this.) (cherry picked from commit 05d9125)
Werkov
added a commit
to Werkov/systemd
that referenced
this pull request
May 29, 2020
User accounts of given names are necessary for the build script and tests to succeed. (Fixup of systemd#15527, too keen cleaning of dependencies and cached image caused this.) (cherry picked from commit 05d9125)
Werkov
added a commit
to Werkov/systemd
that referenced
this pull request
Jun 2, 2020
User accounts of given names are necessary for the build script and tests to succeed. (Fixup of systemd#15527, too keen cleaning of dependencies and cached image caused this.) (cherry picked from commit 05d9125)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This series adds support for mkosi images of openSUSE Tumbleweed. It also touches the mkosi build process but keeps its distrubution-oblivious nature.