Optionally resolve single label names #16059
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
poettering
requested changes
Jun 10, 2020
poettering
added
the
reviewed/needs-rework 🔨
We said that ~domains "do not define a search path", which is mighty confusing, because this is exactly what they do. So let's try to make this a bit easier for the reader: start by saying that there are two things going on here, and describe each one from user's POV.
Access to bit fields is less efficient, and since the Manager is a singleton, a byte or two of space in the structure doesn't matter at all. (And in this particular case, because of alignment issues, we wouldn't save anything anyway.)
Also correct "stub resolver" → "systemd-resolved" in one other option.
keszybz
removed
the
reviewed/needs-rework 🔨
keszybz
force-pushed
the
resolve-single-label-names
branch
from
1a5f06a
to
2bd5e1b
Compare
|
Updated with the suggested changes, though in effect I ended up reworking the description of Domains= yet again. |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.