Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

turn off fuzzit #16064

Merged
merged 1 commit into from Jun 4, 2020
Merged

turn off fuzzit #16064

merged 1 commit into from Jun 4, 2020

Conversation

evverx
Copy link
Member

@evverx evverx commented Jun 4, 2020

It seems it went down yesterday and it's not clear how long it will
take to bring it back.

cc @yevgenypats

It seems it went down yesterday and it's not clear how long it will
take to bring it back.
@evverx evverx added the ci label Jun 4, 2020
@evverx
Copy link
Member Author

evverx commented Jun 4, 2020

I'll go ahead and merge it to make Travis green and prevent it from sending all those notifications to contributors. I'll bring Fuzzit back once it's up and running.

@evverx evverx merged commit b375340 into systemd:master Jun 4, 2020
@evverx evverx deleted the turn-off-fuzzit branch June 4, 2020 14:38
@evverx
Copy link
Member Author

evverx commented Jun 9, 2020

I reverted this commit in #16099 and also introduced a memory leak to see how Fuzzit would react to it. According to https://app.fuzzit.dev/orgs/systemd/targets/fuzz-unit-file-asan-ubsan/Uv1RXERr5S9fJLY8YfMV, the fuzz target crashed but Fuzzit couldn't get the logs:
Screenshot 2020-06-09 at 04 20 12

@yevgenypats could you take a look?

Other than that it seems Fuzzit neither sent an email notification nor reported the issue on the dashboard. I think before turning it on it would make sense to wait until those issues are fixed.

@evverx
Copy link
Member Author

evverx commented Jun 10, 2020

To judge from https://app.fuzzit.dev/orgs/systemd/targets/fuzz-unit-file-asan-ubsan/dusqXY75FoWWZuVSu7wg, the logs are back to normal. The memory leak hasn't been reported by Fuzzit yet though.

evverx added a commit to evverx/systemd that referenced this pull request Jun 11, 2020
it's just a follow-up to systemd#16064
@evverx evverx mentioned this pull request Jun 11, 2020
mrc0mmand pushed a commit that referenced this pull request Jun 11, 2020
it's just a follow-up to #16064
@evverx
Copy link
Member Author

evverx commented Jun 11, 2020

@yevgenypats congratulations on joining GitLab!

In light of the announcement I turned off Fuzzit completely in #16154 but I can't seem to remove the systemd organization to free up the resources. I'd appreciate it if you could remove it (and also my account from there) so as not to waste the CPUs.

@evverx
Copy link
Member Author

evverx commented Jun 11, 2020

On the bright side, now that Fuzzit is gone (along with UBsan and MSan) it seems I'll finally get around to google/oss-fuzz#3421. The patch to OSS-Fuzz is being tested in #16150

@evverx
Copy link
Member Author

evverx commented Jun 11, 2020

@mrc0mmand I wonder if you have access to https://www.freedesktop.org/wiki/Software/systemd/? Could you remove fuzzit (mentioned next to OSS-Fuzz) from there?

@mrc0mmand
Copy link
Member

@mrc0mmand I wonder if you have access to https://www.freedesktop.org/wiki/Software/systemd/? Could you remove fuzzit (mentioned next to OSS-Fuzz) from there?

Unfortunately no. I guess this will have to go through @keszybz.

@evverx
Copy link
Member Author

evverx commented Jun 11, 2020

I'm not sure how important this is but since we no longer use fuzzit, I've just asked the Fuzzit team to remove the logo from the "trusted by" section at https://fuzzit.dev/.

In the meantime, I opened google/oss-fuzz#3969. Once it's reviewed and merged we will be able to bring both MSan and UBsan. With 5 parallel jobs run when PRs are opened we should probably start thinking about canceling jobs. Though I wouldn't worry about that until it's clear it's an issue.

@yevgenypats
Copy link
Contributor

yevgenypats commented Jun 12, 2020 via email

@keszybz
Copy link
Member

keszybz commented Jun 12, 2020 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

None yet

4 participants