vconsole-setup: downgrade log message when setting font fails on dumm… #16503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y console Since commit 883eb9b, vconsole-setup might be called again to operate on dummy console where font operations are not supported but where it's still important to have the correct keymap set [0][1]. vconsole-setup is mainly called by udev but can also be run via a dependency of an early service. Both cases might end up calling vconsole-setup on the dummy console. The first case can happen during early boot even on systems that use (instead of the dummy console) a "simple" video console driver supporting font operations (such as vgacon) until a more specific driver (such as i915) takes the console over. While this is happening vgacon is deactivated and temporarly replaced by the dummy console [2]. There are also other cases where systemd-vconsole-setup might be called on dummy console especially during (very) early boot. Indeed systemd-vconsole-setup.service might be pulled in by early interactive services such as 'dracut-cmdline-ask.service` which is run before udev. If that happens on platforms with no grapical HWs (such as embedded ARM) or with dummy console initially installed until a driver takes over (like Xen and xen-fbfront) then setting font will fail. Therefore this patch downgrades the log message emitted when setting font fails to LOG_DEBUG and when font operations is not implemented like it's the case for the dummy console. Fixes: systemd#16406. [0] systemd#10826 [1] https://bugzilla.redhat.com/show_bug.cgi?id=1652473 [2] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/gpu/vga/vgaarb.c?h=v5.7#n204
fbuihuu
force-pushed
the
vconsole-setup-fix-log
branch
from
7d0b4ca
to
c9cb7e6
Compare
keszybz
added a commit
to keszybz/systemd
that referenced
this pull request
Jul 20, 2020
… input/output" This reverts commit 0b57803. From systemd#16503 (comment): systemd-vconsole-setup (the binary) is supposed to run asynchronously by udev therefore ordering early interactive services after systemd-vconsole-setup.service has basically no effect. Let's remove this paragraph. It's better to say nothing than to give pointless advice.
|
See #16520. |
keszybz
added a commit
that referenced
this pull request
Jul 22, 2020
… input/output" This reverts commit 0b57803. From #16503 (comment): systemd-vconsole-setup (the binary) is supposed to run asynchronously by udev therefore ordering early interactive services after systemd-vconsole-setup.service has basically no effect. Let's remove this paragraph. It's better to say nothing than to give pointless advice.
keszybz
added a commit
to systemd/systemd-stable
that referenced
this pull request
Jul 27, 2020
… input/output" This reverts commit 0b57803. From systemd/systemd#16503 (comment): systemd-vconsole-setup (the binary) is supposed to run asynchronously by udev therefore ordering early interactive services after systemd-vconsole-setup.service has basically no effect. Let's remove this paragraph. It's better to say nothing than to give pointless advice. (cherry picked from commit 8fa2cd8)
sayanchowdhury
pushed a commit
to kinvolk-archives/systemd-legacy
that referenced
this pull request
Aug 3, 2020
… input/output" This reverts commit 0b57803. From systemd/systemd#16503 (comment): systemd-vconsole-setup (the binary) is supposed to run asynchronously by udev therefore ordering early interactive services after systemd-vconsole-setup.service has basically no effect. Let's remove this paragraph. It's better to say nothing than to give pointless advice. (cherry picked from commit 8fa2cd8)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…y console
Since commit 883eb9b, vconsole-setup might be
called again to operate on dummy console where font operations are not
supported but where it's still important to have the correct keymap set [0].
vconsole-setup is mainly called by udev but can also be run via a dependency of
an early service. Both cases might end up calling vconsole-setup on the dummy
console.
The first case can happen during early boot even on systems that use (instead
of the dummy console) a "simple" video console driver supporting font
operations (such as vgacon) until a more specific driver (such as i915) takes
the console over. While this is happening vgacon is deactivated and temporarly
replaced by the dummy console [1].
There are also other cases where systemd-vconsole-setup might be called on
dummy console especially during (very) early boot. Indeed
systemd-vconsole-setup.service might be pulled in by early interactive services
such as 'dracut-cmdline-ask.service` which is run before udev.
If that happens on platforms with no grapical HWs (such as embedded ARM) or
with dummy console initially installed until a driver takes over (like Xen and
xen-fbfront) then setting font will fail.
Therefore this patch downgrades the log message emitted when setting font fails
to LOG_DEBUG and when font operations is not implemented like it's the case for
the dummy console.
Fixes: #16406.
[0] #10826
[1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/gpu/vga/vgaarb.c?h=v5.7#n204