mount: add new SmackFileSystemRoot= setting for mount unit (v4) #1664
Conversation
This option specifies the label to assign the root of the file system if it lacks the Smack extended attribute. Note that this option will be ignored if kernel does not support the Smack feature by runtime checking.
If SMACK is enabled, 'smackfsroot=*' option should be specified when /tmp is mounted since many non-root processes use /tmp for temporary usage. If not, /tmp is labeled as '_' and smack denial occurs when writing. In order to do that, 'SmackFileSystemRoot=*' is newly added into tmp.mount.
mount: add new SmackFileSystemRoot= setting for mount unit (v4)
|
Hm, I know that the name of this option mirrors the kernel parameter to some extent (SmackFileSystemRoot= vs. smackfsroot=), but the name seems misleading. Why not call this SmackFileSystemRootLabel= ? We already have SmackProcessLabel, SmackLabel, ... |
|
True, I think we should rename that. We should stick to the SmackFooLabel= scheme I guess. |
That way it's in sync with the other SMACK label settings. systemd#1664 (comment)
|
OK, I renamed the field now as part of PR #1676. |
|
@again4you hmm, so @karelzak suggested on the mailing list, that this patch is actually not necessary at all, since /bin/mount strips the option away anyway! Any idea what's going on? I'd rather not keep this option in place if we don't need it? @again4you are you using busybox or regular util-linux? |
|
I opened a new issue about this in #1696 now, so that we remove it before the next release again if we don't actually need it, @karelzak and @again4you please comment there. |
|
@poettering btw, this is pretty old story, see: |
That way it's in sync with the other SMACK label settings. systemd#1664 (comment)
That way it's in sync with the other SMACK label settings. systemd#1664 (comment)
That way it's in sync with the other SMACK label settings. systemd#1664 (comment)
This PR fixes #1571 issue by newly adding 'SmackFileSystemRoot=' option for mount unit.
Those patches are tested in both Arch & Tizen 3.0.
Changes since v3