Improve systemd-analyze security a bit and other assorted bits #16640
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I was reading a summary of changes on Phoronix, and (while not incorrect) those two points were rather misleading.
poettering
requested changes
Aug 5, 2020
| assert(a); | ||
| assert(info); | ||
| assert(ret_badness); | ||
| assert(ret_description); | ||
|
|
||
| assert(a->parameter < _SYSCALL_FILTER_SET_MAX); | ||
| f = syscall_filter_sets + a->parameter; | ||
| const SyscallFilterSet *f = syscall_filter_sets + a->parameter; | ||
|
|
There was a problem hiding this comment.
The assert makes sure that the *f assignment is OK.
The two variable declarations below are a separate thing.
poettering
added
the
reviewed/needs-rework 🔨
This information was already available in the debug output, but I think it is good to include it in the message in the table. This makes it easier to wrap one's head around the allowlist/denylist filtering.
This comes up occasionally with new users. The phrase "Logs begin ..." is ambiguous because it can be taken to mean the logs being displayed or all logs (the intended meaning). Let's rephrase this as "Journal begins ..." to make this clearer.
Every time I was using this function I had to check whether "newline" means that newlines are good or bad.
keszybz
removed
the
reviewed/needs-rework 🔨
keszybz
force-pushed
the
various-patches
branch
from
c1a6085
to
3a193ac
Compare
|
Updated to always initialize |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.