Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

man: mention that sd_bus_call() may return negative errno based on D-Bus error reply #17561

Merged
merged 5 commits into from Nov 12, 2020

Conversation

yuwata
Copy link
Member

@yuwata yuwata commented Nov 9, 2020

Closes #17556.

man/sd_bus_call.xml Outdated Show resolved Hide resolved
man/sd-id128.xml Outdated Show resolved Hide resolved
man/sd_id128_to_string.xml Outdated Show resolved Hide resolved
@keszybz keszybz added the reviewed/needs-rework 🔨 PR has been reviewed and needs another round of reworks label Nov 10, 2020
@yuwata yuwata removed the reviewed/needs-rework 🔨 PR has been reviewed and needs another round of reworks label Nov 12, 2020
@yuwata
Copy link
Member Author

yuwata commented Nov 12, 2020

@keszybz Thank you for the review. Updated. PTAL.

Copy link
Member

@keszybz keszybz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor fixup needed. I'll do it in the merge commit.

@@ -104,7 +104,12 @@
<refsect2 id='errors'>
<title>Errors</title>

<para>Returned errors may indicate the following problems:</para>
<para>Returned errors may indicate the following problems. When
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This sentence needs to be moved to the end.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@keszybz keszybz merged commit 141fdc8 into systemd:master Nov 12, 2020
@yuwata yuwata deleted the man branch November 12, 2020 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants