Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make support for nscd flushing optional #17879

Merged
merged 1 commit into from
Dec 7, 2020

Conversation

keszybz
Copy link
Member

@keszybz keszybz commented Dec 7, 2020

Fedora will deprecate support for nscd in the upcoming release [1] and plans to
drop it in the next one [2]. At that point we might as well build systemd
without that support too, since there'll be nothing to talk too.

[1] https://fedoraproject.org/wiki/Changes/DeprecateNSCD
[2] https://fedoraproject.org/wiki/Changes/RemoveNSCD

Fedora will deprecate support for nscd in the upcoming release [1] and plans to
drop it in the next one [2]. At that point we might as well build systemd
without that support too, since there'll be nothing to talk too.

[1] https://fedoraproject.org/wiki/Changes/DeprecateNSCD
[2] https://fedoraproject.org/wiki/Changes/RemoveNSCD
@poettering poettering added the good-to-merge/waiting-for-ci 👍 PR is good to merge, but CI hasn't passed at time of review. Please merge if you see CI has passed label Dec 7, 2020
@bluca
Copy link
Member

bluca commented Dec 7, 2020

bionic-i386 timed out as usual. Error in TEST-02-UNITTESTS on CentOS is unrelated too, although slightly worrying:

08:13:14 --- test-journal-flush begin ---
08:13:14 journal_file_copy_entry failed: Bad message
08:13:14 Assertion 'r >= 0' failed at src/journal/test-journal-flush.c:52, function main(). Aborting.

maybe a bad disk write? Paging @mrc0mmand

@mrc0mmand
Copy link
Member

bionic-i386 timed out as usual. Error in TEST-02-UNITTESTS on CentOS is unrelated too, although slightly worrying:

08:13:14 --- test-journal-flush begin ---
08:13:14 journal_file_copy_entry failed: Bad message
08:13:14 Assertion 'r >= 0' failed at src/journal/test-journal-flush.c:52, function main(). Aborting.

maybe a bad disk write? Paging @mrc0mmand

I noticed that too in several cases over the past several days and it's indeed worrying, since it's failing in the CentOS 7 job (i.e. without nested KVM, just regular KVM). I'm not sure if anything has changed in the journal stuff to cause this though...

@keszybz keszybz removed the good-to-merge/waiting-for-ci 👍 PR is good to merge, but CI hasn't passed at time of review. Please merge if you see CI has passed label Dec 7, 2020
@keszybz keszybz merged commit 7e0079f into systemd:master Dec 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

4 participants