Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

network: Allow to configure unreachable/blackhole RoutingPolicyRule #17984

Merged
merged 2 commits into from Dec 18, 2020
Merged

network: Allow to configure unreachable/blackhole RoutingPolicyRule #17984

merged 2 commits into from Dec 18, 2020

Conversation

ssahani
Copy link
Contributor

@ssahani ssahani commented Dec 15, 2020

closes #17890

@yuwata
Copy link
Member

yuwata commented Dec 15, 2020

Ah, uh, I already started to work on exactly the same rfe... Haha.

@bluca bluca added the good-to-merge/waiting-for-ci 👍 PR is good to merge, but CI hasn't passed at time of review. Please merge if you see CI has passed label Dec 15, 2020
bluca
bluca approved these changes Dec 15, 2020
View reviewed changes
Copy link
Member

@bluca bluca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yuwata yuwata removed the good-to-merge/waiting-for-ci 👍 PR is good to merge, but CI hasn't passed at time of review. Please merge if you see CI has passed label Dec 15, 2020
yuwata
yuwata requested changes Dec 15, 2020
View reviewed changes
man/systemd.network.xml Outdated Show resolved Hide resolved
src/network/networkd-routing-policy-rule.h Outdated Show resolved Hide resolved
@bluca bluca added the reviewed/needs-rework 🔨 PR has been reviewed and needs another round of reworks label Dec 15, 2020
@yuwata
Copy link
Member

yuwata commented Dec 16, 2020

#17994 is merged. Please rebase this.

yuwata
yuwata requested changes Dec 16, 2020
View reviewed changes
src/network/networkd-routing-policy-rule.c Outdated Show resolved Hide resolved
src/network/networkd-routing-policy-rule.c Outdated Show resolved Hide resolved
src/network/networkd-routing-policy-rule.c Outdated Show resolved Hide resolved
man/systemd.network.xml Outdated Show resolved Hide resolved
@ssahani
Copy link
Contributor Author

ssahani commented Dec 16, 2020

updated ptal ! thanks for the review /

yuwata
yuwata requested changes Dec 16, 2020
View reviewed changes
Copy link
Member

@yuwata yuwata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks mostly OK. But please update the document.

man/systemd.network.xml Outdated Show resolved Hide resolved
@yuwata yuwata added good-to-merge/with-minor-suggestions and removed reviewed/needs-rework 🔨 PR has been reviewed and needs another round of reworks labels Dec 16, 2020
@ssahani
Copy link
Contributor Author

ssahani commented Dec 17, 2020

yes updated. thanks !

@yuwata
Copy link
Member

yuwata commented Dec 17, 2020

Uh, please also update the test.

@yuwata yuwata added ci-fails/needs-rework 🔥 Please rework this, the CI noticed an issue with the PR and removed good-to-merge/with-minor-suggestions labels Dec 17, 2020
@ssahani
Copy link
Contributor Author

ssahani commented Dec 17, 2020

Yes done.

@bluca bluca added needs-review and removed ci-fails/needs-rework 🔥 Please rework this, the CI noticed an issue with the PR labels Dec 17, 2020
@yuwata yuwata merged commit d7d1d18 into systemd:master Dec 18, 2020
@yuwata
Copy link
Member

yuwata commented Dec 18, 2020

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yuwata yuwata yuwata requested changes

@bluca bluca bluca approved these changes

Assignees
No one assigned
Labels
documentation network
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow creating unreachable/blackhole RoutingPolicyRule
3 participants
@ssahani @yuwata @bluca