chroot/sd_notify() fixes #18329
Merged
chroot/sd_notify() fixes #18329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…= work Previously if people enabled RootDirectory=/RootImage= and NotifyAccess= together, things wouldn't work, they'd have to explicitly add BindReadOnlyPaths=/run/systemd/notify too. Let's make this implicit. Since both options are opt-in, if people use them together it would be pointless not also defining the BindReadOnlyPaths= entry, in which case we can just do it automatically. See: systemd#18051
MountAPIVFS= implicitly mounts /run as tmpfs now, no need to do this explicitly. The notification socket is now implicitly mounted too, if NotifyAccess= and RootImage=/RootDirectory= are used together.
poettering
added
documentation
pid1
portable
|
LGTM. |
yuwata
added
the
good-to-merge/waiting-for-ci 👍
boucman
reviewed
Jan 21, 2021
bluca
reviewed
Jan 21, 2021
poettering
added a commit
to poettering/systemd
that referenced
this pull request
Jan 21, 2021
This partly reverts fe239c7, where I accidentally dropped only line for /run that was unlike the others. Oops. @bluca, thanks for noticing: systemd#18329 (review)
bluca
pushed a commit
that referenced
this pull request
Jan 21, 2021
This partly reverts fe239c7, where I accidentally dropped only line for /run that was unlike the others. Oops. @bluca, thanks for noticing: #18329 (review)
borna-blazevic
pushed a commit
to sartura/systemd
that referenced
this pull request
Mar 1, 2021
This partly reverts fe239c7, where I accidentally dropped only line for /run that was unlike the others. Oops. @bluca, thanks for noticing: systemd#18329 (review)
borna-blazevic
pushed a commit
to sartura/systemd
that referenced
this pull request
Mar 1, 2021
This partly reverts fe239c7, where I accidentally dropped only line for /run that was unlike the others. Oops. @bluca, thanks for noticing: systemd#18329 (review)
borna-blazevic
pushed a commit
to sartura/systemd
that referenced
this pull request
Mar 1, 2021
This partly reverts fe239c7, where I accidentally dropped only line for /run that was unlike the others. Oops. @bluca, thanks for noticing: systemd#18329 (review)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A fix for #18051