tmpfiles: v/q/Q: Add env var to skip check for rootfs in subvolume #18522
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
poettering
reviewed
Feb 9, 2021
poettering
added
the
reviewed/needs-rework 🔨
|
Oh that makes a lot more sense! I didn't realize that btrfs_subvol_make_fd failes with ENOTTY on other filesystems. I made the changes, and I'm building an image of my OS to test that it still works right now. I'll let you know how it goes |
|
@poettering I tested it. It all works, the only nitpick is the warning that shows up when the env variable is unset (which is 99% of the time) |
Maybe loginfo or logdebug would be better then? |
poettering
requested changes
Feb 10, 2021
|
@poettering I've made the changes you requested |
bluca
removed
the
reviewed/needs-rework 🔨
poettering
added
the
good-to-merge/waiting-for-ci 👍
|
lgtm |
|
Thank you :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #18502
I've compiled this into my distro and it fixes the problem. I also tested it on ext4 with the variable set and it fell back to directories just fine. Without the variable, it behaves just as before