udev: fix importing program result #18885
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a bug introduced by 28a5065. Fixes RHBZ#1935062 (https://bugzilla.redhat.com/show_bug.cgi?id=1935062).
yuwata
force-pushed
the
udev-fix-import-program-rhbz-1935062
branch
from
66a2e2b
to
86c783d
Compare
keszybz
reviewed
Mar 5, 2021
test/units/testsuite-59.sh
Outdated
|
|
||
| echo OK > /testok | ||
|
|
||
| exit 0 |
There was a problem hiding this comment.
I do see that this doesn't fit too well anywhere else, but maybe this could be combined with one of the other tests? Spinning up a VM for this feels wasteful.
yuwata
force-pushed
the
udev-fix-import-program-rhbz-1935062
branch
from
002f205
to
3509c78
Compare
|
For now just ignore the TEST-58 and TEST-56 failures, I'll fix it in CentOS CI once this PR is merged. |
|
coredump issue in TEST-17-UDEV seems not related. See https://github.com/systemd/systemd-centos-ci/blob/e5b63491d8d7447770fb39e37396c492ad496935/agent/testsuite.sh#L168-L172. These lines also needs to be updated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug introduced by 28a5065.
Fixes RHBZ#1935062 (https://bugzilla.redhat.com/show_bug.cgi?id=1935062).