Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cg_unified_cached: return ENOMEDIUM if we cannot find a known hierarchy #19025

Merged
merged 1 commit into from Mar 17, 2021

Conversation

floppym
Copy link
Contributor

@floppym floppym commented Mar 16, 2021

When the test suite is being run in a foreign environment,
/sys/fs/cgroup might not be set up in a way that we recognize.
Returning ENOMEDIUM causes the tests to be skipped in this case.

Bug: https://bugs.gentoo.org/771819

src/basic/cgroup-util.c Outdated Show resolved Hide resolved
@poettering poettering added cgroups reviewed/needs-rework 🔨 PR has been reviewed and needs another round of reworks labels Mar 16, 2021
@floppym
Copy link
Contributor Author

floppym commented Mar 16, 2021

I force-pushed a new version.

src/basic/cgroup-util.c Outdated Show resolved Hide resolved
@poettering
Copy link
Member

there's also a typo on the commit msg ENOMEDUM → ENOMEDIUM

When the test suite is being run in a foreign environment,
/sys/fs/cgroup might not be set up in a way that we recognize.
Returning ENOMEDIUM causes the tests to be skipped in this case.

Bug: https://bugs.gentoo.org/771819
@floppym floppym changed the title cg_unified_cached: return ENOMEDUM if we cannot find a known hierarchy cg_unified_cached: return ENOMEDIUM if we cannot find a known hierarchy Mar 16, 2021
@floppym
Copy link
Contributor Author

floppym commented Mar 16, 2021

Pushed again.

@bluca bluca added needs-review and removed reviewed/needs-rework 🔨 PR has been reviewed and needs another round of reworks labels Mar 17, 2021
Copy link
Member

@bluca bluca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - all requested changes were applied, so setting green label

@poettering
Copy link
Member

lgtm. I think this is simple enough to be merged before 248. Let's get thi in.

@poettering poettering merged commit 2156061 into systemd:main Mar 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

3 participants