Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rules: block - add hd to whitelist, need in Xen guest #2065

Closed
wants to merge 1 commit into from

Conversation

robertalks
Copy link

@olafhering
Copy link
Contributor

Matching "hd*" will solve the bug.

But I wonder why the on-disk links by-label/by-uuid are tied to specific kernel names. Doesnt this implementation mean that every rule to match other block driver not handled in 60-persistent-storage.rules has to duplicate the label/uuid handling?

Perhaps the label/uuid links should be created unconditionally, then "hd*" does not need to be matched.

@poettering
Copy link
Member

Partying like it's 1995, eh? The old /dev/hda drivers are old and undermaintained. Use the newer drivers. If you really want support for /dev/hda, then maintain in downstream, we don't want support for such old stuff that has better replacements in systemd upstream.

@olafhering
Copy link
Contributor

This is not about hardware, but about names. Every block driver is free to pick a name, and xen-blkfront does just that: it picks a name.

@robertalks , please rearrange the code to do the uuid/label symlinks unconditionally.

@poettering
Copy link
Member

@olafhering why would it pick names then that conflict with the old IDE hdd drivers?

@olafhering
Copy link
Contributor

@poettering they do not conflict, instead they make the device node provided by PV drivers look like IDE or SCSI to work around system software which does not cope with things it does not know.

In the end the current bug is the lack of by-label and by-uuid symlinks. Something which I think is really unrelated to underlying storage. Thats why I proposed to create these links unconditionally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

None yet

3 participants