conf-parse: make config_parse_many() optionally save 'struct stat' for each file #21114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This works as a resolution for #21113 |
geissonator
pushed a commit
to openbmc/openbmc
that referenced
this pull request
Oct 25, 2021
Currently, systemd only uses the timestamp of the most recent file for tracking changes to configurations. With multiple drop-in files this results in reloads not picking up changes to older files. This patch fixes the reload behavior. Issue: systemd/systemd#21113 In-Review: systemd/systemd#21114 Change-Id: I9b92995e0d7faa612b51bfd45dd33803cd566441 Signed-off-by: William A. Kennington III <wak@google.com>
poettering
reviewed
Oct 27, 2021
| @@ -580,6 +580,28 @@ int network_load(Manager *manager, OrderedHashmap **networks) { | |||
| return 0; | |||
| } | |||
|
|
|||
| static bool stats_by_path_equal(Hashmap *a, Hashmap *b) { | |||
There was a problem hiding this comment.
is "equal" really the right name for this? maybe "_unmodified"?
There was a problem hiding this comment.
For me, "equal" sounds suitable for "stats", and "unmodified" sounds suitable for "file" (or "path").
So, I prefer "equal" here. But not strong opinion. If you or others prefer "unmodified", then I will rename it.
|
@poettering Thank you for you review. I'd like to keep the function name at least in this PR. I am planning the Hashmap introduced in this PR make also used in PID1. So, I will re-consider the function name if it can be reused and moved to e.g. stat-util.[ch]. Merging. |
jamin-aspeed
pushed a commit
to AspeedTech-BMC/openbmc
that referenced
this pull request
Jan 24, 2022
Currently, systemd only uses the timestamp of the most recent file for tracking changes to configurations. With multiple drop-in files this results in reloads not picking up changes to older files. This patch fixes the reload behavior. Issue: systemd/systemd#21113 In-Review: systemd/systemd#21114 Change-Id: I9b92995e0d7faa612b51bfd45dd33803cd566441 Signed-off-by: William A. Kennington III <wak@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #21113.