Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tree-wide: introduce ERRNO_IS_TRANSIENT() and use it #21564

Merged
merged 5 commits into from Dec 1, 2021
Merged

tree-wide: introduce ERRNO_IS_TRANSIENT() and use it #21564

merged 5 commits into from Dec 1, 2021

Conversation

yuwata
Copy link
Member

@yuwata yuwata commented Nov 29, 2021 •
edited

Hopefully addresses #18817 (comment).

poettering
poettering reviewed Nov 30, 2021
View reviewed changes
src/basic/errno-util.h Outdated Show resolved Hide resolved
@yuwata yuwata changed the title tree-wide: introduce ERRNO_IS_INTERRUPT() and use it tree-wide: introduce ERRNO_IS_TRANSIENT() and use it Nov 30, 2021
@yuwata
Copy link
Member Author

yuwata commented Nov 30, 2021

@poettering Thank you for the suggestion. Now the helper function is renamed to ERRNO_IS_TRANSIENT(). PTAL.

@bluca bluca added good-to-merge/waiting-for-ci 👍 PR is good to merge, but CI hasn't passed at time of review. Please merge if you see CI has passed and removed please-review labels Nov 30, 2021
@bluca
Copy link
Member

bluca commented Nov 30, 2021

I don't think I've seen this fail before in the CentOS CI? @mrc0mmand ?

10:52:01 FAILED TASKS:
10:52:01 -------------
10:52:01 TEST-20-MAINPIDGAMES

@mrc0mmand
Copy link
Member

I don't think I've seen this fail before in the CentOS CI? @mrc0mmand ?

10:52:01 FAILED TASKS:
10:52:01 -------------
10:52:01 TEST-20-MAINPIDGAMES

Interesting, haven't seen this one before. I'll restart both jobs to see if it's just something transient.

@mrc0mmand
Copy link
Member

Looks like it's a real issue, judging from the intermediate results.

@bluca bluca added ci-fails/needs-rework 🔥 Please rework this, the CI noticed an issue with the PR and removed good-to-merge/waiting-for-ci 👍 PR is good to merge, but CI hasn't passed at time of review. Please merge if you see CI has passed labels Nov 30, 2021
@mrc0mmand
Copy link
Member

Local reproducer:

$ git fetch -fu upstream refs/pull/21564/merge:pr
$ git checkout pr
$ meson build -Dinstall-tests=true
$ ninja -C build
# make -C test/TEST-20-MAINPIDGAMES/ clean setup run TEST_NO_NSPAWN=1

@yuwata yuwata added please-review and removed ci-fails/needs-rework 🔥 Please rework this, the CI noticed an issue with the PR labels Nov 30, 2021
@yuwata
Copy link
Member Author

yuwata commented Nov 30, 2021

I found so many errors... I hope now all issues are fixed. But please review carefully. PTAL.

@mrc0mmand

This comment has been minimized.

Sign in to view
@mrc0mmand

This comment has been minimized.

Sign in to view
@bluca bluca added good-to-merge/waiting-for-ci 👍 PR is good to merge, but CI hasn't passed at time of review. Please merge if you see CI has passed and removed please-review labels Nov 30, 2021
@yuwata yuwata merged commit 361bf5f into systemd:main Dec 1, 2021
@yuwata yuwata deleted the errno-eagain-eintr branch December 1, 2021 03:52
@fbuihuu fbuihuu mentioned this pull request Nov 16, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@poettering poettering poettering left review comments

@bluca bluca bluca approved these changes

Assignees
No one assigned
Labels
good-to-merge/waiting-for-ci 👍 PR is good to merge, but CI hasn't passed at time of review. Please merge if you see CI has passed journal network resolve timesync tree-wide udev
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@yuwata @bluca @mrc0mmand @poettering