logind: allow to read /proc #21785
Merged
logind: allow to read /proc #21785
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just drop the line altogether please, instead. |
|
How do we prevent that our forgetful selves won't add it again next year in a quest to improve security? :) |
Maybe adding a test case would help? |
User name and tty are used for wall messages. For that to work logind must be able to poke around in proc entries of other processes.
|
test cases for that would be ideal indeed. Anyway, removed the setting as requested. |
keszybz
added
the
good-to-merge/waiting-for-ci 👍
|
you could also leave a comment in: |
yuwata
added
good-to-merge/with-minor-suggestions
and removed
good-to-merge/waiting-for-ci 👍
bluca
added a commit
to bluca/systemd
that referenced
this pull request
Dec 17, 2021
|
Follow-up with comment in #21801 so that we can get this in for rc3 |
yuwata
pushed a commit
that referenced
this pull request
Dec 17, 2021
keszybz
pushed a commit
to systemd/systemd-stable
that referenced
this pull request
Jan 11, 2022
Follow-up for systemd/systemd#21785 (cherry picked from commit ba679b8)
keszybz
pushed a commit
to systemd/systemd-stable
that referenced
this pull request
Jan 13, 2022
Follow-up for systemd/systemd#21785 (cherry picked from commit ba679b8) (cherry picked from commit d370601)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User name and tty are used for wall messages. For that to work logind
must be able to poke around in proc entries of other processes.