Revert "ci: switch to fedora-35 on i386 on Packit"

[yuwata]

This reverts commit 478c632.

Don't merge this until Fedora rawhide drops GCC-12 or GCC-12 is released.

[evverx]

Thanks!

Just to make it easier to find it in the foreseeable future, systemd failed to compile with gcc-12 on i386 with

FAILED: src/shared/libsystemd-shared-250.a.p/pkcs11-util.c.o 
gcc -Isrc/shared/libsystemd-shared-250.a.p -Isrc/shared -I../src/shared -Isrc/basic -I../src/basic -Isrc/fundamental -I../src/fundamental -Isrc/systemd -I../src/systemd -I. -I.. -I../src/libsystemd/sd-bus -I../src/libsystemd/sd-device -I../src/libsystemd/sd-event -I../src/libsystemd/sd-hwdb -I../src/libsystemd/sd-id128 -I../src/libsystemd/sd-journal -I../src/libsystemd/sd-netlink -I../src/libsystemd/sd-network -I../src/libsystemd/sd-resolve -I/usr/include/blkid -I/usr/include/libmount -I/usr/include/p11-kit-1 -flto=auto -fdiagnostics-color=always -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Wextra -Werror -std=gnu99 -Wno-format-signedness -Wno-missing-field-initializers -Wno-unused-parameter -Wdate-time -Wendif-labels -Werror=format=2 -Werror=implicit-function-declaration -Werror=incompatible-pointer-types -Werror=int-conversion -Werror=overflow -Werror=override-init -Werror=return-type -Werror=shift-count-overflow -Werror=shift-overflow=2 -Werror=undef -Wfloat-equal -Wimplicit-fallthrough=5 -Winit-self -Wlogical-op -Wmissing-include-dirs -Wmissing-noreturn -Wnested-externs -Wold-style-definition -Wpointer-arith -Wredundant-decls -Wshadow -Wstrict-aliasing=2 -Wstrict-prototypes -Wsuggest-attribute=noreturn -Wunused-function -Wwrite-strings -Wno-unused-result -Werror=missing-declarations -Werror=missing-prototypes -fdiagnostics-show-option -fno-common -fno-strict-aliasing -fstack-protector -fstack-protector-strong -fvisibility=hidden --param=ssp-buffer-size=4 -ffunction-sections -fdata-sections -Werror=shadow -include config.h -O2 -flto=auto -ffat-lto-objects -fexceptions -g -grecord-gcc-switches -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -Wp,-D_GLIBCXX_ASSERTIONS -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -fstack-protector-strong -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 -m32 -march=i686 -mtune=generic -msse2 -mfpmath=sse -mstackrealign -fasynchronous-unwind-tables -fstack-clash-protection -fcf-protection -fPIC -pthread -fvisibility=default -MD -MQ src/shared/libsystemd-shared-250.a.p/pkcs11-util.c.o -MF src/shared/libsystemd-shared-250.a.p/pkcs11-util.c.o.d -o src/shared/libsystemd-shared-250.a.p/pkcs11-util.c.o -c ../src/shared/pkcs11-util.c
In file included from ../src/basic/macro.h:12,
                 from ../src/basic/time-util.h:19,
                 from ../src/shared/ask-password-api.h:6,
                 from ../src/shared/pkcs11-util.c:5:
In function ‘freep’,
    inlined from ‘pkcs11_token_login’ at ../src/shared/pkcs11-util.c:240:83:
../src/fundamental/macro-fundamental.h:284:17: error: pointer ‘id_390’ used after ‘free’ [-Werror=use-after-free]
  284 |                 free(memory);                   \
      |                 ^~~~~~~~~~~~
In function ‘freep’,
    inlined from ‘pkcs11_token_login’ at ../src/shared/pkcs11-util.c:240:95:
../src/fundamental/macro-fundamental.h:284:17: note: call to ‘free’ here
  284 |                 free(memory);                   \
      |                 ^~~~~~~~~~~~
In function ‘freep’,
    inlined from ‘pkcs11_token_login’ at ../src/shared/pkcs11-util.c:240:56:
../src/fundamental/macro-fundamental.h:284:17: error: pointer ‘token_uri_escaped_386’ used after ‘free’ [-Werror=use-after-free]
  284 |                 free(memory);                   \
      |                 ^~~~~~~~~~~~
In function ‘freep’,
    inlined from ‘pkcs11_token_login’ at ../src/shared/pkcs11-util.c:240:95:
../src/fundamental/macro-fundamental.h:284:17: note: call to ‘free’ here
  284 |                 free(memory);                   \
      |                 ^~~~~~~~~~~~
cc1: all warnings being treated as errors

[evverx]

@mrc0mmand looking at #22209 (where rawhide-i386 was used instead of fedora-35) it seems Packit doesn't rebase PRs on top of the master branch. I wonder if there is a flag that can be flipped to make Packit rebase/merge PRs by analogy with GHActions for example?

[mrc0mmand]

@mrc0mmand looking at #22209 (where rawhide-i386 was used instead of fedora-35) it seems Packit doesn't rebase PRs on top of the master branch. I wonder if there is a flag that can be flipped to make Packit rebase/merge PRs by analogy with GHActions for example?

Ah, yes, it should be https://packit.dev/docs/configuration/#merge_pr_in_ci - it was implemented recently and I completely forgot to add it to our configuration.

[evverx]

Thanks a lot! If I had known about that flag I wouldn't have kept hitting the same bug over and over again in my elfutils fork :-) I'll turn it on there too. Thanks!

[mrc0mmand]

Thanks a lot! If I had known about that flag I wouldn't have kept hitting the same bug over and over again in my elfutils fork :-) I'll turn it on there too. Thanks!

However, reading the documentation once again, it looks like it should be enabled by default (and the underlying code seems to agree: https://github.com/packit/packit/blob/31978201d42740419abd4ea66f39beed741f9c4d/packit/config/common_package_config.py#L58).

[mrc0mmand]

Please revert e764215 as well.

[yuwata]

Please revert e764215 as well.

Sure. Done.

[mrc0mmand]

The fixed gcc build seems to have landed in Rawhide and after retriggering the Packit builds all of them seem to agree, so this should be ready to go!

[yuwata]

@mrc0mmand and @evverx Now rawhide seems OK. PTAL.

[evverx]

Looks like Packit is happy. Thanks!

[evverx]

@mrc0mmand I've just noticed that you approved the PR 19 hours ago. Is it OK that I merged it?

[mrc0mmand]

@mrc0mmand I've just noticed that you approved the PR 19 hours ago. Is it OK that I merged it?

Definitely, I was actually waiting for your approval :-)

[evverx]

I still think that in general unreleased compilers shouldn't be used to test systemd but considering that bugs are reported and fixed I think with fedora rawhide it should be fine :-) Thanks for reporting that bug!