-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: use CFLite to test forks (including systemd-stable) #22295
Conversation
Maybe: on:
push:
branches:
- main
- v[0-9]+-stable
pull_request:
paths:
- tools/oss-fuzz.sh |
Ah, I see what you mean. I guess in that case something like: if: github.repository != 'systemd/systemd' || (github.event_name == 'pull_request' && github.event.pull_request.user.login == 'dependabot[bot]') should work, but it's not very elegant. Another option would be getting the list of changes from the |
Thanks!
I'll take a look at how the labeler action does that. As far as I know it gets the list of files changed in PRs and compare them with its config. Then again maybe I'm just overthinking it and it should be fine to just skip it here with
|
I'm not sure what's up with Packit :-) I think it's almost ready. I'm trying to figure out whether Dependabot can really update docker images. Once it's done I'll change |
It's like CIFuzz but unlike CIFuzz it's compatible with forks and it should make it possible to run the fuzzers to make sure that patches backported to them are backported correctly without introducing new bugs and regressions.
@mrc0mmand I think it should be ready for review. I tested it and judging by https://github.com/evverx/systemd/actions/runs/1766409686 (where it was triggered on a PR) and https://github.com/evverx/systemd/actions/runs/1766402069 (where it was triggered on a commit) it seems to be working. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's nifty, thanks!
Not sure if it's ready to be merged (given the red label), so feel free to merge it once it is. |
It's like CIFuzz but unlike CIFuzz it's compatible with forks and
it should make it possible to run the fuzzers to make sure that
patches backported to them are backported correctly without introducing
new bugs and regressions.
@mrc0mmand could you take a look? I'm going to unleash it on my fork to make sure it works but in the meantime I'm not sure how to turn it off here properly. It should include something like
to avoid clogging up the GHActions pool here but at the same time it should be run here when Dependabot updates the actions or when
tools/oss-fuzz.sh
is changed.