Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: merge seed corpora with public OSS-Fuzz corpora on CFLite #22302

Merged
merged 2 commits into from Jan 30, 2022

Conversation

evverx
Copy link
Member

@evverx evverx commented Jan 29, 2022

to let it cover as much code as possible. It should help to catch most regressions in a few minutes.

@evverx
Copy link
Member Author

evverx commented Jan 29, 2022

Judging by https://github.com/systemd/systemd/actions/runs/1767066906 it seems to be working. For example the fuzz-varlink seed corpus was merged with the OSS-Fuzz corpus and the fuzzer used 5088 files (instead of 10)

INFO: Running with entropic power schedule (0xFF, 100).
INFO: Seed: 1337
INFO: Loaded 2 modules   (74432 inline 8-bit counters): 74344 [0x7f3e542ed4d0, 0x7f3e542ff738), 88 [0x5bea28, 0x5bea80), 
INFO: Loaded 2 PC tables (74432 PCs): 74344 [0x7f3e542ff738,0x7f3e54421db8), 88 [0x57d028,0x57d5a8), 
INFO:     5088 files found in /github/workspace/cifuzz-corpus/fuzz-varlink

@evverx evverx marked this pull request as ready for review January 29, 2022 23:58
@evverx evverx marked this pull request as draft January 30, 2022 01:46
@evverx
Copy link
Member Author

evverx commented Jan 30, 2022

It's blocked by google/clusterfuzzlite#84 :-(

to let it cover as much code as possible. It should help to catch
most regressions in a few minutes.
The idea behind this action is to make it possible to compare the
latest fuzz targets with PRs to figure out whether bugs are really
reproducible in PRs only. Since forks (including systemd-stable) are
usually based on the upstream repository where almost all the bugs
are fixed before releases are cut it should be safe to assume that
if CFLite finds bugs in PRs they are most likely introduced in those
PRs.

It should probably be brought back once google/clusterfuzzlite#84
is fixed.
@evverx
Copy link
Member Author

evverx commented Jan 30, 2022

@mrc0mmand to get it around I decided to no longer upload artifacts containing the latest build

ci: no longer upload the latest builds on commits

The idea behind this action is to make it possible to compare the
latest fuzz targets with PRs to figure out whether bugs are really
reproducible in PRs only. Since forks (including systemd-stable) are
usually based on the upstream repository where almost all the bugs
are fixed before releases are cut it should be safe to assume that
if CFLite finds bugs in PRs they are most likely introduced in those
PRs.

It should probably be brought back once https://github.com/google/clusterfuzzlite/issues/84
is fixed.

The action is being tested in https://github.com/evverx/systemd/runs/4997912999?check_suite_focus=true and once it's green it should be good to go I think.

@evverx evverx marked this pull request as ready for review January 30, 2022 17:23
@mrc0mmand
Copy link
Member

Looks like CI is happy with this change (given the job you've posted), so LGTM.

@evverx evverx added the reviewed/needs-rework 🔨 PR has been reviewed and needs another round of reworks label Jan 30, 2022
@evverx evverx removed the reviewed/needs-rework 🔨 PR has been reviewed and needs another round of reworks label Jan 30, 2022
@mrc0mmand
Copy link
Member

Still LGTM, thanks! Let's wait for the job to finish.

@mrc0mmand mrc0mmand added the good-to-merge/waiting-for-ci 👍 PR is good to merge, but CI hasn't passed at time of review. Please merge if you see CI has passed label Jan 30, 2022
@mrc0mmand mrc0mmand merged commit 15391a2 into systemd:main Jan 30, 2022
@evverx evverx deleted the merge-oss-fuzz-corpora branch January 31, 2022 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci good-to-merge/waiting-for-ci 👍 PR is good to merge, but CI hasn't passed at time of review. Please merge if you see CI has passed
Development

Successfully merging this pull request may close these issues.

None yet

2 participants