Fix transient units memory leak #2328
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes: ==1== HEAP SUMMARY: ==1== in use at exit: 67,182 bytes in 91 blocks ==1== total heap usage: 70,485 allocs, 70,394 frees, 42,184,635 bytes allocated ==1== ==1== 5,742 (696 direct, 5,046 indirect) bytes in 29 blocks are definitely lost in loss record 4 of 7 ==1== at 0x4C2DD9F: realloc (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so) ==1== by 0x21ADDD: realloc_multiply (alloc-util.h:67) ==1== by 0x21BFB0: strv_push (strv.c:448) ==1== by 0x21C245: strv_consume (strv.c:520) ==1== by 0x21C33C: strv_extend (strv.c:559) ==1== by 0x278AD7: unit_write_drop_in (unit.c:3352) ==1== by 0x278EEB: unit_write_drop_in_private (unit.c:3403) ==1== by 0x190C21: bus_service_set_transient_property (dbus-service.c:254) ==1== by 0x190DBC: bus_service_set_property (dbus-service.c:284) ==1== by 0x18F00E: bus_unit_set_properties (dbus-unit.c:1226) ==1== by 0x186F6A: transient_unit_from_message (dbus-manager.c:683) ==1== by 0x1872B7: method_start_transient_unit (dbus-manager.c:763) ==1== ==1== LEAK SUMMARY: ==1== definitely lost: 696 bytes in 29 blocks ==1== indirectly lost: 5,046 bytes in 58 blocks ==1== possibly lost: 0 bytes in 0 blocks ==1== still reachable: 61,440 bytes in 4 blocks ==1== suppressed: 0 bytes in 0 blocks
zonque
added a commit
that referenced
this pull request
Jan 15, 2016
Fix transient units memory leak
evverx
added a commit
to evverx/systemd
that referenced
this pull request
Jan 18, 2016
We need a beautiful stacktraces sometimes For example systemd#2328
evverx
added a commit
to evverx/systemd
that referenced
this pull request
Jan 18, 2016
We need a beautiful stacktraces sometimes For example systemd#2328
tblume
pushed a commit
to tblume/systemd-testsuite-suse
that referenced
this pull request
Mar 8, 2016
We need a beautiful stacktraces sometimes For example systemd/systemd#2328
tblume
pushed a commit
to tblume/systemd-testsuite-suse
that referenced
this pull request
Aug 6, 2018
We need a beautiful stacktraces sometimes For example systemd/systemd#2328
fbuihuu
pushed a commit
to fbuihuu/systemd-opensuse-next
that referenced
this pull request
Apr 11, 2019
We need a beautiful stacktraces sometimes For example systemd/systemd#2328 (cherry picked from commit 5a61346)
fbuihuu
pushed a commit
to fbuihuu/systemd-opensuse-next
that referenced
this pull request
Apr 11, 2019
We need a beautiful stacktraces sometimes For example systemd/systemd#2328 (cherry picked from commit 5a61346)
fbuihuu
pushed a commit
to openSUSE/systemd
that referenced
this pull request
Apr 29, 2019
We need a beautiful stacktraces sometimes For example systemd/systemd#2328 (cherry picked from commit 5a61346)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes:
How to reproduce:
rw init=/valgrinized-systemdwhile :; do systemd-run /bin/true; donesystemctl poweroff