tpm2-util: force default TCTI to be "device" with parameter "/dev/tpm… #25393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuwata
approved these changes
Nov 15, 2022
…rm0" Apparently some distros default to tss-abmrd. Let's bypass that and always go to the kernel resource manager. abmrd cannot really work for us, since we want to access the TPM already in earliest boot i.e. in environments the abmrd service is not available in. Fixes: systemd#25352
Let's add some extra validation before constructing and using the .so name to load. This isn't really security sensitive, given that we used secure_getenv() to get the device string (and it thus should have been come from a trusted source) but let's better be safe than sorry.
poettering
force-pushed
the
tpm2-override
branch
from
edeb3f2
to
50a0851
Compare
|
I reworked the patch set a bit, adding a way for people to explicitly request the default device picking logic of tpm2-tss if they want by setting the device env var to an empty string. |
|
dropping green label since reworked quite a bit, and I added a second commit |
bluca
approved these changes
Nov 15, 2022
bluca
added
the
good-to-merge/waiting-for-ci 👍
yuwata
approved these changes
Nov 16, 2022
keszybz
removed
good-to-merge/waiting-for-ci 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…rm0"
Apparently some distros default to tss-abmrd. Let's bypass that and always go to the kernel resource manager.
abmrd cannot really work for us, since we want to access the TPM already in earliest boot i.e. in environments the abmrd service is not available in.
Fixes: #25352