bootctl: avoid using __WORDSIZE macro #26412
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
__WORDSIZE does not seem to be documented anywhere, and is probably meant to be used internally by glibc headers. In systemd, it was only being used in warning messages. We can avoid using it by rewording the messages slightly. Fixes a build error with musl libc. Bug: https://bugs.gentoo.org/894430
github-actions
bot
added
sd-boot/sd-stub/bootctl
please-review
|
An -rc1 tag has been created and a release is being prepared, so please note that PRs introducing new features and APIs will be held back until the new version has been released. |
yuwata
approved these changes
Feb 15, 2023
yuwata
added
good-to-merge/waiting-for-ci 👍
|
This just updates log messages. Hence, should be ok to merge even after -rc3. |
github-actions
bot
removed
the
good-to-merge/waiting-for-ci 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
__WORDSIZE does not seem to be documented anywhere, and is probably meant to be used internally by glibc headers.
In systemd, it was only being used in warning messages. We can avoid using it by rewording the messages slightly.
Fixes a build error with musl libc.
Bug: https://bugs.gentoo.org/894430