core/manager: run generators directly when we are in initrd #26494
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some initrd system write files at ourside of /run, /etc, or other allowed places. This is a kind of workaround, but in most cases, such sandboxing is not necessary as the filesystem is on ramfs when we are in initrd. Fixes systemd#26488.
github-actions
bot
added
the
please-review
|
This doesn't look right. The goal of the sandboxing was to trip up generators "with side-effects", i.e. that write files outside of the generator output dirs. So the right fix is to fix those generators, not work around them in our code, neither in the initrd nor elsewhere. |
|
OK. Thank you for the comments. I initially thought that we should postpone to apply the sandbox in initrd to give a time to dracut or other initrd build tools to update their generators. But, if we postpone the change, it is easily expected that no change will come until we re-apply the sandbox. Closing. |
gerrit-photon
pushed a commit
to vmware/photon
that referenced
this pull request
Mar 29, 2023
lvm with latest systemd and dracut doesn't boot up. Upstream issues for reference: - dracut: dracutdevs/dracut#2211 - systemd: systemd/systemd#26488 Temporary patch applied until this issue is resolved systemd/systemd#26494 See systemd/systemd#26488 (comment) Change-Id: I1964ff2a82b7c2d6c53e02b4368a8d5d6f9a03a1 Signed-off-by: Tapas Kundu <tkundu@vmware.com> Reviewed-on: http://photon-jenkins.eng.vmware.com:8082/20134
gerrit-photon
pushed a commit
to vmware/photon
that referenced
this pull request
Mar 31, 2023
lvm with latest systemd and dracut doesn't boot up. Upstream issues for reference: - dracut: dracutdevs/dracut#2211 - systemd: systemd/systemd#26488 Temporary patch applied until this issue is resolved systemd/systemd#26494 See systemd/systemd#26488 (comment) Change-Id: I1964ff2a82b7c2d6c53e02b4368a8d5d6f9a03a1 Reviewed-on: http://photon-jenkins.eng.vmware.com:8082/20132 Tested-by: gerrit-photon <photon-checkins@vmware.com> Reviewed-by: Susant Sahani <ssahani@vmware.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some initrd system write files at ourside of /run, /etc, or other allowed places. This is a kind of workaround, but in most cases, such sandboxing is not necessary as the filesystem is on ramfs when we are in initrd.
Fixes #26488.