base-filesystem: Support Arch-style multilib #26645
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On distros like Arch and on carbonOS, libraries end up in /usr/lib. Thus, /lib64 should point to /usr/lib. This commit adds this functionality as a final fallback (if neither Debian-style nor Fedora-style multilib can be detected)
|
I haven't tested this yet. Would you want me to add a test case for it? |
github-actions
bot
added
util-lib
please-review
poettering
reviewed
Mar 3, 2023
|
lgtm, but please update the comment |
poettering
added
good-to-merge/with-minor-suggestions
and removed
please-review
|
So, I was informed that arch-style multilib does exist, and it uses /usr/lib32/ as kind of an inverse of fedora-style /usr/lib64. Here's my question though: what about /lib32/? if that exists we'd have to create that symlink here. But I take it that is not a thing, only /usr/lib32/ exists? under the assumption that's the case, then I guess this still looks OK. |
poettering
added
good-to-merge/waiting-for-ci 👍
|
I can't tell if the CI failure has much to do with this MR... can someone take a look and/or rerun the test? How does this work? |
bluca
approved these changes
Mar 6, 2023
github-actions
bot
removed
the
good-to-merge/waiting-for-ci 👍
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On distros like Arch and on carbonOS, libraries end up in /usr/lib. Thus, /lib64 should point to /usr/lib. This commit adds this functionality as a final fallback (if neither Debian-style nor Fedora-style multilib can be detected)
As discussed on the mailing list