Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

scope: do not disable timer event source when state is SCOPE_RUNNING #27144

Merged
merged 2 commits into from Apr 13, 2023
Merged

scope: do not disable timer event source when state is SCOPE_RUNNING #27144

merged 2 commits into from Apr 13, 2023

Commits on Apr 13, 2023

  1. scope: do not disable timer event source when state is SCOPE_RUNNING 

    In scope_set_state(), the timer event source may be disabled depending
on the state. Currently, it will be disabled when the state is
SCOPE_RUNNING. This has the effect of new RuntimeMaxSec values being
ignored on coldplug.

Note that this issue is not currently present when scopes are started
because when scope_start() is called, scope_arm_timer() is called after
scope_set_state().
    @enr0n
    enr0n committed Apr 13, 2023
    Configuration menu
    Copy the full SHA
    e1f85b4 View commit details
    Browse the repository at this point in the history

  2. test: add some tests for RuntimeMaxSec 

    Make sure the RuntimeMaxSec is applied correctly to service and scope
units when they are started, and also on coldplug.
    @enr0n
    enr0n committed Apr 13, 2023
    Configuration menu
    Copy the full SHA
    af46883 View commit details
    Browse the repository at this point in the history