-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ukify: allow building PE mule #27362
Conversation
split out of #27358 |
"mule" sounds like it would be something that would transport cocaine over the border... can't we find a less crime-affine name? |
hmm, the primary job of ukify should still be building UKIs, hence I would make this functionality a bit harder to reach when just forgetting to specify thing. i.e. add a new switch to build such images. or make it so that |
I think they use submarines these days |
Make the kernel optional too, so that we can easily build and sign a PE addon, that can be used to carry extra command line options.
There's no |
Ah, right. But then at least add --no-linux or so |
code-wise looks all good to me. will leave thorough review to @keszybz |
will all be combined into a single PE section. This is useful to for example prepend microcode before the | ||
actual initrd.</para> | ||
<para>The <replaceable>LINUX</replaceable> and <replaceable>INITRD</replaceable> positional arguments are | ||
optional. If more than one <replaceable>INITRD</replaceable> are specified, they will all be combined into |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
are specified → is specified
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's merge this. I'll need to rebase #27262 to adjust to this, I can fix the one grammar nit then too.
FWIW, I like "mule". |
Make the kernel optional too, so that we can easily build and sign a PE mule, that can be used to carry extra command line options.