Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ukify: allow building PE mule #27362

Merged
merged 1 commit into from
Apr 26, 2023
Merged

ukify: allow building PE mule #27362

merged 1 commit into from
Apr 26, 2023

Conversation

bluca
Copy link
Member

@bluca bluca commented Apr 22, 2023

Make the kernel optional too, so that we can easily build and sign a PE mule, that can be used to carry extra command line options.

@bluca bluca added the uki label Apr 22, 2023
@bluca
Copy link
Member Author

bluca commented Apr 22, 2023

split out of #27358

@github-actions github-actions bot added documentation please-review PR is ready for (re-)review by a maintainer labels Apr 22, 2023
@poettering
Copy link
Member

"mule" sounds like it would be something that would transport cocaine over the border...

can't we find a less crime-affine name?

@poettering
Copy link
Member

hmm, the primary job of ukify should still be building UKIs, hence I would make this functionality a bit harder to reach when just forgetting to specify thing.

i.e. add a new switch to build such images. or make it so that --linux=/dev/null selects this mode.

@bluca
Copy link
Member Author

bluca commented Apr 24, 2023

"mule" sounds like it would be something that would transport cocaine over the border...

can't we find a less crime-affine name?

I think they use submarines these days

Make the kernel optional too, so that we can easily build and sign a PE addon,
that can be used to carry extra command line options.
@bluca
Copy link
Member Author

bluca commented Apr 24, 2023

hmm, the primary job of ukify should still be building UKIs, hence I would make this functionality a bit harder to reach when just forgetting to specify thing.

i.e. add a new switch to build such images. or make it so that --linux=/dev/null selects this mode.

There's no --linux option, it's positional. Forcing to pass a random /dev/null looks quite bad from usability POV.

@poettering
Copy link
Member

There's no --linux option, it's positional. Forcing to pass a random /dev/null looks quite bad from usability POV.

Ah, right. But then at least add --no-linux or so

@poettering
Copy link
Member

code-wise looks all good to me. will leave thorough review to @keszybz

will all be combined into a single PE section. This is useful to for example prepend microcode before the
actual initrd.</para>
<para>The <replaceable>LINUX</replaceable> and <replaceable>INITRD</replaceable> positional arguments are
optional. If more than one <replaceable>INITRD</replaceable> are specified, they will all be combined into
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are specified → is specified

Copy link
Member

@keszybz keszybz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's merge this. I'll need to rebase #27262 to adjust to this, I can fix the one grammar nit then too.

@keszybz
Copy link
Member

keszybz commented Apr 26, 2023

FWIW, I like "mule".

@keszybz keszybz merged commit 00e5933 into systemd:main Apr 26, 2023
47 checks passed
@github-actions github-actions bot removed the please-review PR is ready for (re-)review by a maintainer label Apr 26, 2023
@bluca bluca deleted the ukify_mule branch April 26, 2023 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

3 participants