loginctl: list-{users,sessions}: add a column for showing state #27606
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
please-review
yuwata
requested changes
May 15, 2023
yuwata
added
reviewed/needs-rework 🔨
YHNdnzj
force-pushed
the
loginctl-list-show-state
branch
from
14038c6
to
70f8230
Compare
github-actions
bot
added
tests
please-review
YHNdnzj
force-pushed
the
loginctl-list-show-state
branch
from
70f8230
to
7e969f2
Compare
|
@YHNdnzj I wonder: is the state really so useful to users that it needs to be listed? It seems nobody has ever asked for this... |
yuwata
approved these changes
May 15, 2023
yuwata
added
good-to-merge/waiting-for-ci 👍
bluca
added
ci-fails/needs-rework 🔥
|
@bluca I don't think the CI failures are related? |
Don't worry about the shellcheck stuff - a new version of shellcheck got out with additional checks. I'll fix it when I do another round of shell-related fixes. |
YHNdnzj
added
good-to-merge/waiting-for-ci 👍
poettering
reviewed
May 16, 2023
poettering
reviewed
May 16, 2023
poettering
reviewed
May 16, 2023
poettering
added
good-to-merge/with-minor-suggestions
and removed
good-to-merge/waiting-for-ci 👍
YHNdnzj
force-pushed
the
loginctl-list-show-state
branch
3 times, most recently
from
23d2757
to
82a7c53
Compare
|
one of those days, if we keep adding properties to the table we should add a new version of the ListSession() and other methods that just pass the data along entirely. The many roundtrips really suck. but that is for another time i guess. |
poettering
added
good-to-merge/waiting-for-ci 👍
|
lgtm |
YHNdnzj
force-pushed
the
loginctl-list-show-state
branch
from
82a7c53
to
306ff2e
Compare
github-actions
bot
removed
the
good-to-merge/waiting-for-ci 👍
This was referenced Aug 15, 2023
dustymabe
added a commit
to dustymabe/zincati
that referenced
this pull request
Aug 15, 2023
In systemd 254 the `loginctl list-sessions --json` output was modified slightly:
Before
```
[{"session":"4","uid":1000,"user":"core","seat":"","tty":""}]
```
After
```
[{"session":"17","uid":1000,"user":"core","seat":"","tty":"n/a","state":"active","idle":false,"since":null}]
```
Notice the change from `""` to `"n/a"` for the `tty` field.
This change probably happened in one of:
- systemd/systemd#27769
- systemd/systemd#27740
- systemd/systemd#27606
Let's update the code to handle the new case.
Fixes coreos/fedora-coreos-tracker#1547
dustymabe
added a commit
to dustymabe/zincati
that referenced
this pull request
Aug 15, 2023
In systemd 254 the `loginctl list-sessions --json` output was modified slightly:
Before
```
[{"session":"4","uid":1000,"user":"core","seat":"","tty":""}]
```
After
```
[{"session":"17","uid":1000,"user":"core","seat":"","tty":"n/a","state":"active","idle":false,"since":null}]
```
Notice the change from `""` to `"n/a"` for the `tty` field.
This change probably happened in one of:
- systemd/systemd#27769
- systemd/systemd#27740
- systemd/systemd#27606
Let's update the code to handle the new case and rename the function to
be a little more appropriate since the use case for it is narrow.
Fixes coreos/fedora-coreos-tracker#1547
dustymabe
added a commit
to dustymabe/zincati
that referenced
this pull request
Aug 15, 2023
In systemd 254 the `loginctl list-sessions --json` output was modified slightly:
Before
```
[{"session":"4","uid":1000,"user":"core","seat":"","tty":""}]
```
After
```
[{"session":"17","uid":1000,"user":"core","seat":"","tty":"n/a","state":"active","idle":false,"since":null}]
```
Notice the change from `""` to `"n/a"` for the `tty` field.
This change probably happened in one of:
- systemd/systemd#27769
- systemd/systemd#27740
- systemd/systemd#27606
Let's update the code to handle the new case and rename the function to
be a little more appropriate since the use case for it is narrow.
Fixes coreos/fedora-coreos-tracker#1547
dustymabe
added a commit
to dustymabe/zincati
that referenced
this pull request
Aug 15, 2023
In systemd 254 the `loginctl list-sessions --json` output was modified slightly:
Before
```
[{"session":"4","uid":1000,"user":"core","seat":"","tty":""}]
```
After
```
[{"session":"17","uid":1000,"user":"core","seat":"","tty":"n/a","state":"active","idle":false,"since":null}]
```
Notice the change from `""` to `"n/a"` for the `tty` field.
This change probably happened in one of:
- systemd/systemd#27769
- systemd/systemd#27740
- systemd/systemd#27606
Let's update the code to handle the new case and rename the function to
be a little more appropriate since the use case for it is narrow.
Fixes coreos/fedora-coreos-tracker#1547
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.