Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

execute: fix the condition of private mounts for user namespacing #28037

Merged
merged 1 commit into from Jun 15, 2023
Merged

execute: fix the condition of private mounts for user namespacing #28037

merged 1 commit into from Jun 15, 2023

Conversation

hexchain
Copy link
Contributor

@hexchain hexchain commented Jun 14, 2023 •
edited

See #26744 (comment) and following comments.

@github-actions github-actions bot added the please-review PR is ready for (re-)review by a maintainer label Jun 14, 2023
@hexchain hexchain mentioned this pull request Jun 14, 2023
Closed
@bluca
Copy link
Member

bluca commented Jun 14, 2023

mmh there are some tests in src/test/test-execute to adjust, probably simply adapt the return code, can you run it locally and check?

@bluca bluca added pid1 ci-fails/needs-rework 🔥 Please rework this, the CI noticed an issue with the PR rc-blocker 🚧 PRs and Issues tagged this way are blocking the upcoming rc release! and removed please-review PR is ready for (re-)review by a maintainer labels Jun 14, 2023
@bluca bluca added this to the v254 milestone Jun 14, 2023
@bluca bluca linked an issue Jun 14, 2023 that may be closed by this pull request
Logged out session still tracked by logind #26744
Closed
@bluca bluca removed a link to an issue Jun 14, 2023
Logged out session still tracked by logind #26744
Closed
@hexchain hexchain force-pushed the fix-need-user-namespacing-check branch from f362a97 to 545cf7d Compare June 15, 2023 02:17
@github-actions github-actions bot added tests please-review PR is ready for (re-)review by a maintainer and removed ci-fails/needs-rework 🔥 Please rework this, the CI noticed an issue with the PR labels Jun 15, 2023
@hexchain hexchain force-pushed the fix-need-user-namespacing-check branch 5 times, most recently from 92bdfc7 to 991280a Compare June 15, 2023 03:50
@hexchain
Copy link
Contributor Author

Unit tests seem to pass now, but I cannot decipher the remaining failures.

@poettering
Copy link
Member

Could you add Follow-up for: 6ef721cbc7dadee4ae878ecf0076d87e57233908 to the commit msg, please?

@poettering
Copy link
Member

lgtm otherwise

@hexchain hexchain force-pushed the fix-need-user-namespacing-check branch from 991280a to 82ee00b Compare June 15, 2023 06:54
@hexchain
Copy link
Contributor Author

Done.

@poettering
Copy link
Member

lgtm, but i'll leave the merge to @bluca

@bluca bluca added good-to-merge/waiting-for-ci 👍 PR is good to merge, but CI hasn't passed at time of review. Please merge if you see CI has passed and removed tests please-review PR is ready for (re-)review by a maintainer labels Jun 15, 2023
@poettering poettering merged commit adeff82 into systemd:main Jun 15, 2023
46 of 48 checks passed
@github-actions github-actions bot removed the good-to-merge/waiting-for-ci 👍 PR is good to merge, but CI hasn't passed at time of review. Please merge if you see CI has passed label Jun 15, 2023
@hexchain hexchain deleted the fix-need-user-namespacing-check branch June 29, 2023 12:23
@bluca bluca removed the rc-blocker 🚧 PRs and Issues tagged this way are blocking the upcoming rc release! label Mar 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bluca bluca bluca approved these changes

Assignees
No one assigned
Labels
pid1
Milestone
v254
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@hexchain @bluca @poettering