test: check if we correctly propagate /run mounts during switch root #28456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
An -rc1 tag has been created and a release is being prepared, so please note that PRs introducing new features and APIs will be held back until the new version has been released. |
mrc0mmand
force-pushed
the
test-mount-propagation
branch
from
3be5271
to
ed2ad0b
Compare
Since 7c764d4 we bind mount certain directories during switch root instead of moving the mount directly, and for /run we do this without MS_REC. This, unfortunately, leaves all mounts under /run behind in the old root, which breaks certain use cases. See: systemd#28452
mrc0mmand
force-pushed
the
test-mount-propagation
branch
from
ed2ad0b
to
d6591dc
Compare
|
@mrc0mmand Could you also add similar tests for soft-reboot? I guess similar issue should be in the operation. |
This is actually part of the issue - the soft-reboot PR added the MS_BIND stuff and it expects /run to get cleared on switch root, so the TEST-82-SOFTREBOOT fails with the proposed fix (in #28454). So there's the question if we want to revert back to preserving /run in all cases or single out soft-reboot. |
|
superseded by #28497 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since 7c764d4 we bind mount certain directories during switch root instead of moving the mount directly, and for /run we do this without MS_REC. This, unfortunately, leaves all mounts under /run behind in the old root, which breaks certain use cases.
See: #28452