fido_id: try report_descriptor from the actual device #29294
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes: systemd#29278 Signed-off-by: Alexander Bokovoy <abokovoy@redhat.com>
github-actions
bot
added
udev
please-review
bluca
reviewed
Sep 24, 2023
| @@ -93,6 +94,7 @@ static int run(int argc, char **argv) { | |||
| if (r < 0) | |||
| return log_device_error_errno(device, r, "Failed to get parent HID device: %m"); | |||
|
|
|||
| repeat: | |||
There was a problem hiding this comment.
this leaks desc_path, please use a do-while instead with scoped variables
bluca
added
reviewed/needs-rework 🔨
|
I'll turn back to the drawing table, somehow |
github-actions
bot
removed
the
reviewed/needs-rework 🔨
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #29278