Minor commits for tpm2 #29426
Merged
Minor commits for tpm2 #29426
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
util-lib
tests
sd-boot/sd-stub/bootctl
repart
tpm2
please-review
bluca
added
needs-rebase
and removed
please-review
Allow providing no bind key, and use ESYS_TR_NONE instead.
The test expects TPM2_CC_FIRST - 1 and TPM2_CC_LAST + 1 to be unsupported, but those are not necessarily invalid commands. Instead test known-invalid commands. Also add some more valid commands.
…ap max value Simplify the function with GREEDY_REALLOC_APPEND(). Also limit the size_t-sized max value to UINT32_MAX since that's the maximum of the range this searches, and the max parameter for tpm2_get_capability() is uint32_t.
…ring This matches the change to tpm2_seal(), which now accepts a Tpm2Context instead of a device string. This also allows using the same TPM context for sealing and unsealing, which will be required by (future) test code when sealing/unsealing using a transient key.
This brings the tpm2_supports_ecc_curve() api in line with the other tpm2_supports_*() functions, of returning a boolean.
ddstreet
force-pushed
the
tpm2_minor_changes
branch
from
624bb82
to
639dca0
Compare
github-actions
bot
added
please-review
DaanDeMeyer
approved these changes
Oct 3, 2023
DaanDeMeyer
added
good-to-merge/waiting-for-ci 👍
bluca
approved these changes
Oct 3, 2023
github-actions
bot
removed
the
good-to-merge/waiting-for-ci 👍
poettering
reviewed
Oct 4, 2023
| @@ -402,6 +402,8 @@ static int tpm2_get_capability_handles( | |||
| assert(ret_handles); | |||
| assert(ret_n_handles); | |||
|
|
|||
| max = MIN(max, UINT32_MAX); | |||
There was a problem hiding this comment.
wouldn't it make more sense to leave "max" as is is, but simply reduce the range passed to tpm2_get_capability(). i.e. allow ridiculous sizes to be returned if people ask for it, but never pass them to the tpm2 apis?
i.e. drop this line here, but instead change the 4th param of tpm2_get_capability() below to do MIN(max, UINT32_MAX)?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are some minor changes for tpm2, split out from #28519 and on top of #29425.