more pidfdification #29594
Merged
more pidfdification #29594
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
journal
sd-bus
systemctl
cgtop
coredump
please-review
bluca
approved these changes
Oct 17, 2023
bluca
added
good-to-merge/with-minor-suggestions
and removed
please-review
YHNdnzj
reviewed
Oct 18, 2023
YHNdnzj
reviewed
Oct 18, 2023
YHNdnzj
added
reviewed/needs-rework 🔨
poettering
force-pushed
the
cgroup-rename-ret-params
branch
from
20baab9
to
bf0a6ea
Compare
github-actions
bot
added
please-review
|
Addressed all points raised (except for the FOREACH_ARRAY thing, which doesn't work, see above) |
poettering
force-pushed
the
cgroup-rename-ret-params
branch
from
bf0a6ea
to
9053ef3
Compare
YHNdnzj
approved these changes
Oct 18, 2023
|
LGTM, and these are minor things except the question on |
The process exists as long as the kernel/userns exists at all, hence we don't have to verify a pidfd to it.
This way we can be sure to provide an atomic view of the process tree of a unit.
This simply checks if the specified PidRef refers to the process we are running in. (In case you wonder why this is not a static inline: to avoid cyclic header inclusion problems between pidref.h + process-util.h)
…ref_is_alive() Let's no eat up errors, but propagate unexpected ones.
poettering
force-pushed
the
cgroup-rename-ret-params
branch
from
9053ef3
to
1158b06
Compare
|
addressed remaining issues (well, except for as discussed above) |
YHNdnzj
added
good-to-merge/waiting-for-ci 👍
github-actions
bot
removed
the
good-to-merge/waiting-for-ci 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ports a bunch of more things over to PidRef and pidfds. Far from done, but PID 1 is look pretty good now. (other daemons much less so)