automatic support for host-to-host networking that only does link-local addressing #29767
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
please-review
poettering
force-pushed
the
host-to-host
branch
from
ce646cf
to
45d8136
Compare
|
(I also notified NM folks about this: https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/issues/1413) |
|
/cc @thom311 |
poettering
force-pushed
the
host-to-host
branch
from
45d8136
to
3fb4204
Compare
yuwata
requested changes
Oct 30, 2023
|
Please also disable IPv6AcceptRA=, which is enabled by default. |
thom311
reviewed
Oct 30, 2023
…local addressing This is a generalization of this logic: https://github.com/NetworkManager/NetworkManager/blob/main/data/90-nm-thunderbolt.rules It applies not just to thunderbolt, but to any kind of device, even matched by vendor/product, via hwdb. I added two entries for Prolific PC-to-PC devices (of which I have one lying around).
…LY=1 This is name ".network.example" for now, to match the existing 80-ethernet.network file. I think it would make sense to actually install this by default if told so via a meson file (and then hopefully this would happen even on Fedora, though in a split off RPM or so). However, we aren't there yet, hence for now, just ship the .network files as example, like the others.
poettering
force-pushed
the
host-to-host
branch
from
3fb4204
to
779a183
Compare
poettering
changed the title
yuwata
approved these changes
Oct 31, 2023
github-actions
bot
removed
the
please-review
thom311
pushed a commit
to NetworkManager/NetworkManager
that referenced
this pull request
Oct 31, 2023
This property has the same meaning than ours NM_AUTO_DEFAULT_LINK_LOCAL_ONLY. It is a good idea to check for it because systemd will flag with it a higher number of devices, and we might consider it as the new "standard" at least for systemd based distros. See systemd/systemd#29767. Maintain NM_AUTO_DEFAULT_LINK_LOCAL_ONLY for compatibility reasons, and give it precedence over the systemd one. It is specific to NM and users could add it to overwrite a systemd's default without having to modify systemd files.
thom311
added a commit
to NetworkManager/NetworkManager
that referenced
this pull request
Nov 2, 2023
We honored "NM_AUTO_DEFAULT_LINK_LOCAL_ONLY" udev property, for when we generate a "Wired connection 1" (aka the "auto-default connection"). Systemd now also honors and may set ID_NET_AUTO_LINK_LOCAL_ONLY for a similar purpose. Honore that too. The NM specific variable still is preferred, also because "NM_AUTO_DEFAULT_LINK_LOCAL_ONLY" is about something very NetworkManager specific (controlling "Wired connection 1"). Maybe one day, we should drop "data/90-nm-thunderbolt.rules" and only rely on what systemd provides. But not yet. See-also: systemd/systemd#29767 https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/issues/1413
thom311
added a commit
to NetworkManager/NetworkManager
that referenced
this pull request
Nov 2, 2023
systemd/systemd#29768 systemd/systemd#29782 systemd/systemd#29767 https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/issues/1413 https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/issues/1414 https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/merge_requests/1780 https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/merge_requests/1779
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds some basic support for automatic host-to-host networking (i.e. direct connections between two systems with network connectivity that does not involve the Internet).
This is a generalization of https://github.com/NetworkManager/NetworkManager/blob/main/data/90-nm-thunderbolt.rules#L11 but also covers Prolific host-to-host USB devices.